Skip to content

Fix Word legacy spelling errors reporting#19972

Merged
SaschaCowley merged 2 commits into
nvaccess:betafrom
CyrilleB79:legacyWordErrors
Apr 20, 2026
Merged

Fix Word legacy spelling errors reporting#19972
SaschaCowley merged 2 commits into
nvaccess:betafrom
CyrilleB79:legacyWordErrors

Conversation

@CyrilleB79
Copy link
Copy Markdown
Contributor

Link to issue number:

Fix-up of #17997

Reported on French mailing list.

Summary of the issue:

In 2026.1beta versions, spelling errors are no longer reported in Word legacy.

Description of user facing changes:

Spelling errors can now again be reported in Word legacy.

Description of developer facing changes:

N/A

Description of development approach:

In #17997, the config key "reportSpellingErrors" has been modified to "reportSpellingErrors2" due to upgrade. But one use of this config key has been forgotten. It is being fixed here.

Testing strategy:

Manual tests with legacy and UIA Word.

Known issues with pull request:

N/A

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@CyrilleB79 CyrilleB79 changed the base branch from master to beta April 18, 2026 21:24
@CyrilleB79 CyrilleB79 marked this pull request as ready for review April 19, 2026 21:10
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner April 19, 2026 21:10
@CyrilleB79 CyrilleB79 requested a review from SaschaCowley April 19, 2026 21:10
@CyrilleB79
Copy link
Copy Markdown
Contributor Author

There are failed system tests, but I guess they are unrelated.
Having them failing quite regularly make us ignore them though what is probably not desirable.

@seanbudd seanbudd added this to the 2026.1 milestone Apr 20, 2026
@SaschaCowley SaschaCowley enabled auto-merge (squash) April 20, 2026 02:09
@SaschaCowley SaschaCowley disabled auto-merge April 20, 2026 05:04
@SaschaCowley SaschaCowley merged commit abc2ecd into nvaccess:beta Apr 20, 2026
163 of 181 checks passed
@CyrilleB79 CyrilleB79 deleted the legacyWordErrors branch April 24, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants