Fix regression: prevent errors in the add-on store

[nvdaes]

• Fix regression in addon store
• Improve method
• Add comments

Link to issue number:

Fixes #19984

Summary of the issue:

When opening the add-on store o requesting for add-on updates, errors are registered in the log, related to VirusTotal.

Description of user facing changes:

No errors Will be registered due to VirusTotal key.

Description of developer facing changes:

None.

Description of development approach:

Use different data to créate a dictionary from ScanResults class, for installed add-ons and add-ons available in the store.

Testing strategy:

Checked that the store can be opened without errors.

Known issues with pull request:

None.

Code Review Checklist:

• Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons.
• Security precautions taken.

[CyrilleB79]

@nvdaes if I understand correctly, you do not modify the format of the _cachedCompatibleAddons.json file here.
That mean that this file will remain with the 1-millon character long data string in its data field as described in #19984 (comment)?

Let's see what NV Access (@seanbudd or @SaschaCowley) thinks of it.

[seanbudd]

Closing in favour of #19996

[nvdaes]

@CyrilleB79 wrote:

if I understand correctly, you do not modify the format of the _cachedCompatibleAddons.json file

In fact. I thought that this would be a drastic change and I toke a different approach.
But I think that this PR will be superseeded by #19996