Skip to content

Fix File Explorer search box losing focus after Ctrl+F #20022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cary-rowen wants to merge 2 commits into
base: master
Choose a base branch
from
+14 −0
Open

Fix File Explorer search box losing focus after Ctrl+F #20022

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f35f83
Fix File Explorer search box focus regression
cary-rowen Apr 27, 2026
5a12952
Merge branch 'master' into fix-explorer-search-pane-focus
cary-rowen Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions source/appModules/explorer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,12 @@ def _get_container(self):
return super(MultitaskingViewFrameListItem, self).container


class SearchBoxClient(IAccessible):
# #20021: File Explorer can fire a redundant MSAA focus event on the search band pane
# immediately after the UIA SearchEditBox gains focus.
shouldAllowIAccessibleFocusEvent = False


# Class for menu items for Windows Places and Frequently used Programs (in start menu)
# Also used for desktop items
class SysListView32EmittingDuplicateFocusEvents(IAccessible):
Expand Down Expand Up @@ -225,6 +231,14 @@ def chooseNVDAObjectOverlayClasses(self, obj, clsList): # NOQA: C901
windowClass = obj.windowClassName
role = obj.role

if (
windowClass in ("Search Box", "UniversalSearchBand")
and role == controlTypes.Role.PANE
and isinstance(obj, IAccessible)
):
clsList.insert(0, SearchBoxClient)
return # Optimization: return early to avoid comparing class names and roles that will never match.

if windowClass == "ToolbarWindow32":
if role != controlTypes.Role.POPUPMENU:
try:
Expand Down
Loading