Fix: Mouse bug -> switch getKeyState with getAsyncKeyState

[Boumtchack]

Link to issue number:

fixes #19691

Summary of the issue:

When using the fullscreen magnifier in Center mode, clicking on controls in certain apps (Discord, Microsoft Teams, HyperX NGENUITY Beta) had no effect. The magnifier transform could shift between the physical button press and Windows applying it to the click coordinates, causing the click to land at the wrong logical position.

Description of user facing changes:

Mouse clicks on controls in apps such as Discord, Microsoft Teams, and HyperX NGENUITY Beta should work correctly when the fullscreen magnifier is running in Center mode.

Description of developer facing changes:

Replaced winUser.getKeyState / mouseHandler.isLeftMouseButtonLocked with winUser.getAsyncKeyState in FocusManager.getCurrentFocusCoordinates and FullScreenMagnifier._keepMouseCentered. Updated tests accordingly.

Description of development approach:

tKeyState is queue-based and can return a stale button state in the wx main thread when the message queue hasn't yet processed the click event. Switching to GetAsyncKeyState ensures the magnifier detects a button press immediately, preventing the Center mode transform from shifting between the physical press and Windows applying it to the click coordinates.

Testing strategy:

Unit

Known issues with pull request:

Code Review Checklist:

• Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons.
• Security precautions taken.

[Copilot]

Pull request overview

This PR addresses mis-targeted mouse clicks when the full-screen magnifier is running in Center mode by switching from message-queue-based key state to GetAsyncKeyState, so the magnifier can reliably detect mouse button presses immediately and avoid repositioning the cursor mid-click.

Changes:

• Replace mouse-button detection with winUser.getAsyncKeyState in magnifier focus tracking (FocusManager.getCurrentFocusCoordinates).
• Replace winUser.getKeyState with winUser.getAsyncKeyState in _keepMouseCentered to avoid interfering with active clicks.
• Update unit tests to mock the new API usage.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
source/_magnifier/utils/focusManager.py	Use getAsyncKeyState for left-button detection; broaden exception handling for review point retrieval.
source/_magnifier/fullscreenMagnifier.py	Use getAsyncKeyState for left/right/middle button checks before cursor repositioning.
tests/unit/test_magnifier/test_focusManager.py	Update tests to reflect the new async key state path.
tests/unit/test_magnifier/test_fullscreenMagnifier.py	Update mocks/patching to target getAsyncKeyState.

[seanbudd]

Thanks @Boumtchack

[seanbudd]

Can you please make sure unit tests pass?