fix: announce all content inside role="alert"

[mehm8128]

Link to issue number:

close #14990

Summary of the issue:

The content of HTML element with role="alert" had only announced its focusable children contents.

Description of user facing changes:

NVDA now announces all content inside role="alert" elements.

Description of developer facing changes:

Description of development approach:

I removed if conditional branch, so all children contents will be announced.
This was introduced in mehm8128@370d052 18 years ago, but

The text of the alert is contained in the description of the alert itself, as it uses the Dialog NVDAObject.

is not correct now, this causes the issue I fixed for this PR, so I removed if conditional branch.

I extended the condition of what role is announced. I added heading, list, listitem, and paragraph roles.

Testing strategy:

test with sample code described in the original issue and confirm that all contents inside role="alert" are announced.
on both Chromium and Firefox, it performs as expected.

Known issues with pull request:

Code Review Checklist:

• Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons.
• Security precautions taken.

[Copilot]

Pull request overview

Fixes NVDA’s handling of HTML/ARIA role="alert" so that alert events announce the full contents of the alert container (not just focusable descendants), addressing #14990.

Changes:

• Update IAccessible alert event handling to speak all recursive descendants of an alert container.
• Add a user-facing changelog entry noting improved role="alert" announcements.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
source/NVDAObjects/IAccessible/__init__.py	Expands alert announcement logic to iterate through and announce all descendant content.
user_docs/en/changes.md	Documents the user-facing change for role="alert" announcements.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

[Qchristensen]

changes.md line reads well.

[seanbudd]

can you merge in latest master please?

[seanbudd]

There may be some double speaking if the author of the HTML does the right thing and sets aria-description or aria-describedby. Have you tested this case? If there's double speaking, can you consider adding a filter to check if the description is there and therefore just do focusable children like now.