Turn cache expiration time into a variable#20058
Merged
Merged
Conversation
seanbudd
commented
May 6, 2026
seanbudd
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the cache expiration threshold in the “Clear caches” GitHub Actions workflow configurable via a repository variable (with an optional workflow dispatch override), instead of being effectively fixed at 6 hours.
Changes:
- Allow
CACHE_EXPIRATION_HOURto be sourced fromvars.CACHE_EXPIRATION_HOURwhen no dispatch input is provided. - Adjust the workflow dispatch input description to be less specific about the previous default.
seanbudd
commented
May 6, 2026
seanbudd
commented
May 6, 2026
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
SaschaCowley
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
Caches expire after 6 hours, it would be nice if we could increase that number higher, to maybe 8-12.
Description of user facing changes:
None
Description of developer facing changes:
We can tweak cache expiration via github variables
Description of development approach:
Add variable
Testing strategy:
Test workflow run for the branch: https://github.com/nvaccess/nvda/actions/runs/25411277902
Will test more thoroughly on prod, it's low danger
Known issues with pull request:
None