Skip to content

Clean up the magnifying glass-related code.#20079

Merged
seanbudd merged 5 commits intonvaccess:masterfrom
hwf1324:codeCleanup
May 8, 2026
Merged

Clean up the magnifying glass-related code.#20079
seanbudd merged 5 commits intonvaccess:masterfrom
hwf1324:codeCleanup

Conversation

@hwf1324
Copy link
Copy Markdown
Contributor

@hwf1324 hwf1324 commented May 7, 2026

Link to issue number:

Summary of the issue:

Clean up the magnifying glass-related code.

Description of user facing changes:

None

Description of developer facing changes:

Clean up the magnifying glass-related code.

Description of development approach:

  • Remove duplicate screen curtain checks.
  • Type hint: Added @override annotation.
  • fix tyype hint
  • Remove redundant return
  • rename filter variable to currentFilter, Because it shadows a builtin functions.

Testing strategy:

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@hwf1324 hwf1324 requested a review from a team as a code owner May 7, 2026 14:14
@hwf1324 hwf1324 requested a review from SaschaCowley May 7, 2026 14:14
Comment thread source/_magnifier/fullscreenMagnifier.py
@seanbudd seanbudd removed the request for review from SaschaCowley May 8, 2026 01:15
Copy link
Copy Markdown
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hwf1324

@seanbudd seanbudd merged commit 58d44a6 into nvaccess:master May 8, 2026
34 of 37 checks passed
@github-actions github-actions Bot added this to the 2026.2 milestone May 8, 2026
@hwf1324 hwf1324 deleted the codeCleanup branch May 8, 2026 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants