Avoid bundling duplicate libmathcat_py.pyd#20081
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates NVDA’s frozen-build packaging rules to avoid shipping an extra copy of libmathcat_py.pyd from the bundled MathCAT assets, reducing installer/launcher size while keeping libmathcat_py import behavior unchanged.
Changes:
- Exclude importable module suffixes (via
importlib.machinery.all_suffixes()) when recursively collecting../include/nvda-mathcat/assetsdata files, matching the existing approach already used for other bundled directories.
seanbudd
reviewed
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #20046
Summary of the issue:
libmathcat_py.pydis created both in the NVDA installation directory and ininclude\nvda-mathcat\assets.Description of user facing changes:
Reduces the size of the launcher by ~4 MB.
Description of developer facing changes:
None;
libmathcat_pycan still be imported the same way. The duplicate being removed was not imported or used by any other code.Description of development approach:
Excludes importable files in the same way that is already used for
synthDriverson line 389 ofsetup.py.Testing strategy:
Built and checked that
libmathcat_py.pydis no longer duplicated, and read math in Chrome as a smoke test.Known issues with pull request:
None.
Code Review Checklist: