Include winBindings.cfgmgr32 in binary builds#20090
Merged
Merged
Conversation
This was referenced May 9, 2026
Merged
Member
|
Can this please be rebased on RC? |
Contributor
Author
|
Already RC branch |
Member
|
@cary-rowen - I updated the target from master to RC, but the branch still needs to be rebased. Otherwise 100+ commits from master will be moved over to RC |
e80d387 to
422ae84
Compare
Contributor
Author
|
Rebased the branch onto |
SaschaCowley
approved these changes
May 14, 2026
Member
SaschaCowley
left a comment
There was a problem hiding this comment.
Thanks, @cary-rowen. Would you like to be credited in the change log?
422ae84 to
d722b0b
Compare
seanbudd
reviewed
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #20089
Summary of the issue:
winBindings.cfgmgr32is documented in the 2026.1 developer changes as the replacement location for several deprecatedhwPortUtilssymbols, but it is not included in binary builds.Description of user facing changes:
None.
Description of developer facing changes:
winBindings.cfgmgr32will be available in binary builds, matching the documented add-on API migration path.Description of development approach:
Explicitly include
winBindings.cfgmgr32in the py2exeincludeslist, since it is referenced dynamically byhwPortUtilsdeprecation aliases and is not discovered by static import analysis.Testing strategy:
Manual testing:
Attempted to import
winBindings.cfgmgr32from the NVDA Python Console.Known issues with pull request:
None known.
Code Review Checklist: