Skip to content

Include winBindings.cfgmgr32 in binary builds#20090

Merged
seanbudd merged 4 commits into
nvaccess:rcfrom
cary-rowen:include-cfgmgr32-binary-build
May 15, 2026
Merged

Include winBindings.cfgmgr32 in binary builds#20090
seanbudd merged 4 commits into
nvaccess:rcfrom
cary-rowen:include-cfgmgr32-binary-build

Conversation

@cary-rowen
Copy link
Copy Markdown
Contributor

@cary-rowen cary-rowen commented May 9, 2026

Link to issue number:

Closes #20089

Summary of the issue:

winBindings.cfgmgr32 is documented in the 2026.1 developer changes as the replacement location for several deprecated hwPortUtils symbols, but it is not included in binary builds.

Description of user facing changes:

None.

Description of developer facing changes:

winBindings.cfgmgr32 will be available in binary builds, matching the documented add-on API migration path.

Description of development approach:

Explicitly include winBindings.cfgmgr32 in the py2exe includes list, since it is referenced dynamically by hwPortUtils deprecation aliases and is not discovered by static import analysis.

Testing strategy:

Manual testing:
Attempted to import winBindings.cfgmgr32 from the NVDA Python Console.

Known issues with pull request:

None known.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@cary-rowen cary-rowen marked this pull request as ready for review May 9, 2026 04:59
@cary-rowen cary-rowen requested a review from a team as a code owner May 9, 2026 04:59
@cary-rowen cary-rowen requested a review from seanbudd May 9, 2026 04:59
@seanbudd seanbudd added this to the 2026.1.1 milestone May 11, 2026
@seanbudd seanbudd changed the base branch from master to rc May 11, 2026 04:10
@seanbudd seanbudd requested a review from a team as a code owner May 11, 2026 04:10
@seanbudd seanbudd requested a review from Qchristensen May 11, 2026 04:10
@seanbudd
Copy link
Copy Markdown
Member

Can this please be rebased on RC?

@cary-rowen
Copy link
Copy Markdown
Contributor Author

Already RC branch
Thanks @seanbudd

@seanbudd
Copy link
Copy Markdown
Member

@cary-rowen - I updated the target from master to RC, but the branch still needs to be rebased. Otherwise 100+ commits from master will be moved over to RC

@cary-rowen cary-rowen force-pushed the include-cfgmgr32-binary-build branch from e80d387 to 422ae84 Compare May 11, 2026 04:55
@cary-rowen
Copy link
Copy Markdown
Contributor Author

Rebased the branch onto
c. The PR now contains only one commit and only changes source/setup.py.

@SaschaCowley SaschaCowley added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label May 12, 2026
Copy link
Copy Markdown
Member

@SaschaCowley SaschaCowley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cary-rowen. Would you like to be credited in the change log?

@SaschaCowley SaschaCowley removed request for a team and Qchristensen May 14, 2026 03:04
@cary-rowen cary-rowen force-pushed the include-cfgmgr32-binary-build branch from 422ae84 to d722b0b Compare May 14, 2026 04:02
@seanbudd seanbudd enabled auto-merge (squash) May 15, 2026 00:49
@seanbudd seanbudd closed this May 15, 2026
auto-merge was automatically disabled May 15, 2026 01:54

Pull request was closed

@seanbudd seanbudd reopened this May 15, 2026
@seanbudd seanbudd closed this May 15, 2026
@seanbudd seanbudd reopened this May 15, 2026
@seanbudd seanbudd enabled auto-merge (squash) May 15, 2026 01:57
Comment thread user_docs/en/changes.md Outdated
@seanbudd seanbudd merged commit be6e95e into nvaccess:rc May 15, 2026
68 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include winBindings.cfgmgr32 in binary builds

3 participants