When NVDA is started, display in braille if screen curtain is enabled#20097
Merged
Conversation
Collaborator
Author
|
pre-commit.ci run |
1 similar comment
Collaborator
Author
|
pre-commit.ci run |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds braille feedback at startup when Screen Curtain is active, addressing a gap for braille-only users (Fixes #19441).
Changes:
- Compute a startup braille message that can include “screen curtain enabled” when appropriate.
- Add a changelog entry for the new braille feedback.
- Fix/adjust markdown list formatting in issue-reporting documentation.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| user_docs/en/changes.md | Documents the new braille startup indication for Screen Curtain. |
| source/core.py | Adds conditional startup braille message selection for Screen Curtain state. |
| projectDocs/issues/readme.md | Adjusts markdown list formatting in issue-reporting docs. |
| projectDocs/issues/githubIssueTemplateExplanationAndExamples.md | Adjusts markdown list formatting in issue template docs. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Collaborator
Author
|
I think that, for simplicity, it's better to show the braille message when screen curtain is enabled, even if the option to play a sound is disabled.
For now I'll change this according to this comment. If needed, the last commit that I'll make now can be reverted. |
…guration when NVDA is started
seanbudd
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #19441
Summary of the issue:
When NVDA is started with the screen curtain enabled, optionally, NVDA can play a sound warning about this, but braille users aren't informed.
Description of user facing changes:
If screen curtain is enabled, a message displayed in braille Will report this when NVDA is started.
Description of developer facing changes:
None.
Description of development approach:
In
core.py, aninitialMessagevariable has been created. Its value would be the current message ("NVDA started"), or a message like "NVDA started with screen curtain enabled").Testing strategy:
I've performed two kind of tests:
screenCurtain.pyto be displayed in braille after a delay. This makes NVDA to display this message, but not the message shown when NVDA is started.Known issues with pull request:
None.
Code Review Checklist: