Skip to content

When NVDA is started, display in braille if screen curtain is enabled#20097

Merged
seanbudd merged 7 commits into
nvaccess:betafrom
nvdaes:brailleScreenCurtain
May 15, 2026
Merged

When NVDA is started, display in braille if screen curtain is enabled#20097
seanbudd merged 7 commits into
nvaccess:betafrom
nvdaes:brailleScreenCurtain

Conversation

@nvdaes
Copy link
Copy Markdown
Collaborator

@nvdaes nvdaes commented May 10, 2026

Link to issue number:

Fixes #19441

Summary of the issue:

When NVDA is started with the screen curtain enabled, optionally, NVDA can play a sound warning about this, but braille users aren't informed.

Description of user facing changes:

If screen curtain is enabled, a message displayed in braille Will report this when NVDA is started.

Description of developer facing changes:

None.

Description of development approach:

In core.py, an initialMessage variable has been created. Its value would be the current message ("NVDA started"), or a message like "NVDA started with screen curtain enabled").

Testing strategy:

I've performed two kind of tests:

  • Trying to add the message in screenCurtain.py to be displayed in braille after a delay. This makes NVDA to display this message, but not the message shown when NVDA is started.
  • Adding the message to core.py in a variable. This is displayed in a reliable way, according to my tests, when appropriate.

Known issues with pull request:

None.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@nvdaes
Copy link
Copy Markdown
Collaborator Author

nvdaes commented May 10, 2026

pre-commit.ci run

1 similar comment
@nvdaes
Copy link
Copy Markdown
Collaborator Author

nvdaes commented May 10, 2026

pre-commit.ci run

@nvdaes nvdaes marked this pull request as ready for review May 10, 2026 14:12
@nvdaes nvdaes requested review from a team as code owners May 10, 2026 14:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds braille feedback at startup when Screen Curtain is active, addressing a gap for braille-only users (Fixes #19441).

Changes:

  • Compute a startup braille message that can include “screen curtain enabled” when appropriate.
  • Add a changelog entry for the new braille feedback.
  • Fix/adjust markdown list formatting in issue-reporting documentation.

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.

File Description
user_docs/en/changes.md Documents the new braille startup indication for Screen Curtain.
source/core.py Adds conditional startup braille message selection for Screen Curtain state.
projectDocs/issues/readme.md Adjusts markdown list formatting in issue-reporting docs.
projectDocs/issues/githubIssueTemplateExplanationAndExamples.md Adjusts markdown list formatting in issue template docs.

Comment thread source/core.py Outdated
Comment thread user_docs/en/changes.md
nvdaes and others added 2 commits May 10, 2026 16:20
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@nvdaes nvdaes marked this pull request as draft May 10, 2026 17:20
@nvdaes
Copy link
Copy Markdown
Collaborator Author

nvdaes commented May 10, 2026

I think that, for simplicity, it's better to show the braille message when screen curtain is enabled, even if the option to play a sound is disabled.
Reasons are:

  • A braille message informing that NVDA has been started will be shown anyway, so this is not an extra but just a different message.
    • It's tricky to change the label of the control including something like "sounds and braille, since the braille message won't be shown when NVDA is quit.
    • Perhaps hearing impaired (or other) people don't want to hear the sound, but a longer message in braille is not anoying and can be displayed for all users.
    • This is used just when NVDA is started, since in other cases, i.e., when screen curtain is enabled/disabled manually, a braille message will be shown.

For now I'll change this according to this comment. If needed, the last commit that I'll make now can be reverted.

@nvdaes nvdaes marked this pull request as ready for review May 10, 2026 18:22
@seanbudd seanbudd changed the base branch from master to beta May 11, 2026 08:17
@seanbudd seanbudd added this to the 2026.2 milestone May 11, 2026
@seanbudd seanbudd changed the base branch from beta to master May 11, 2026 09:33
@seanbudd seanbudd changed the base branch from master to beta May 11, 2026 09:33
@SaschaCowley SaschaCowley added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label May 12, 2026
Copy link
Copy Markdown
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nvdaes

@seanbudd seanbudd merged commit 862eeab into nvaccess:beta May 15, 2026
33 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Screen curtain: add option to speak/display toggle messages

4 participants