Rework magnifier edge messages to ease translation

[CyrilleB79]

Link to issue number:

Reported in this thread of the translators mailing list.

Summary of the issue:

Magnifier had 2 strings "left" for 2 different uses:

• one used as adverb when panning left command was used while already at left edge of the screen to report no move
• one other used in compound string "{edge} edge" as an adjective when panning to left edge command was used while already at left of the screen

In some languages, both strings do not translate the same.

Same for "right", "top" and "bottom" strings.

Description of user facing changes:

Panning command feedback when at edge can now be correctly translated.

Description of developer facing changes:

N/A

Description of development approach:

• Used 1 string per action with no duplicate
• Do not use a compound string since it is no longer needed; this coumpound string was useful only when paning commands were always reporting something but this behaviour has been withdrawn. Moreover, compound strings may be less easy to translate for translators.

Testing strategy:

• Manual tests of all 8 paning commands at 8 edges.

Known issues with pull request:

None

Code Review Checklist:

• Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons.
• Security precautions taken.

[CyrilleB79]

@Boumtchack you may want to check this PR.

[CyrilleB79]

Failing tests are unrelated.