Revert "Don't use IA2TextTextInfo on the web for object review and read line."#20133
Closed
jcsteh wants to merge 2 commits into
Closed
Revert "Don't use IA2TextTextInfo on the web for object review and read line."#20133jcsteh wants to merge 2 commits into
jcsteh wants to merge 2 commits into
Conversation
…ad line.…" This reverts commit 3ad497a.
Contributor
Author
|
I can't rebase this properly because line endings in some projectDocs files aren't normalised, so every time I reset, git thinks the files are modified, and rebase requires no uncommitted changes. |
Contributor
Author
|
Damn it, now I can't push to this branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts PR
Reverts #20096.
Issues fixed
Fixes #20096 (comment) and #20096 (comment).
Issues reopened
None, but we'll need to move #15159 to 2026.3.
Reason for revert
The implementation in #20096 still reviewed the wrong content if you focused a control by pressing tab in focus mode or if you used the review top/bottom line commands. I submitted #20132, but given the proximity to beta, it seems safer to wait for 2026.3 instead.
Can this PR be reimplemented? If so, what is required for the next attempt
#20132.