Skip to content

Revert "Don't use IA2TextTextInfo on the web for object review and re…#20134

Merged
seanbudd merged 1 commit into
nvaccess:betafrom
jcsteh:revertNoIa2Ti
May 15, 2026
Merged

Revert "Don't use IA2TextTextInfo on the web for object review and re…#20134
seanbudd merged 1 commit into
nvaccess:betafrom
jcsteh:revertNoIa2Ti

Conversation

@jcsteh
Copy link
Copy Markdown
Contributor

@jcsteh jcsteh commented May 14, 2026

Reverts PR

Reverts #20096.

Issues fixed

Fixes #20096 (comment) and #20096 (comment).

Issues reopened

Reopens #15159.

Reason for revert

The implementation in #20096 still reviewed the wrong content if you focused a control by pressing tab in focus mode or if you used the review top/bottom line commands. I submitted #20132, but given the proximity to beta, it seems safer to wait for 2026.3 instead.

Can this PR be reimplemented? If so, what is required for the next attempt

See #20132.

@jcsteh jcsteh marked this pull request as ready for review May 14, 2026 12:18
@jcsteh jcsteh requested a review from a team as a code owner May 14, 2026 12:18
@jcsteh jcsteh requested a review from seanbudd May 14, 2026 12:18
@seanbudd seanbudd added this to the 2026.2 milestone May 14, 2026
Copy link
Copy Markdown
Member

@seanbudd seanbudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jcsteh

@seanbudd seanbudd merged commit 7c3a454 into nvaccess:beta May 15, 2026
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants