Skip to content

Cherry-pick "Fix File Explorer search box losing focus after Ctrl+F (#20022)" to rc#20138

Merged
seanbudd merged 4 commits into
rcfrom
20022-to-rc
May 15, 2026
Merged

Cherry-pick "Fix File Explorer search box losing focus after Ctrl+F (#20022)" to rc#20138
seanbudd merged 4 commits into
rcfrom
20022-to-rc

Conversation

@SaschaCowley
Copy link
Copy Markdown
Member

@SaschaCowley SaschaCowley commented May 15, 2026

Cherry-picks #20022 to rc, for inclusion in 2026.1.1.

Fixes #20021
Summary of the issue:

In File Explorer on Windows 10, pressing Ctrl+F should move focus directly to the search edit field. Since NVDA 2026.1 beta, NVDA first reports the search edit field, but then reports a pane, so users need to press Ctrl+F a second time before they can reliably type in the search box.

This is a regression from #19117. That PR removed several old Windows 8.x Start screen workarounds from the Explorer app module, including SearchBoxClient. Although that class was described as a Windows 8 workaround, it was still filtering a redundant File Explorer search band focus event. On Windows 10, the redundant object has:

role == controlTypes.Role.PANE
windowClassName == "Search Box"

Description of user facing changes:

Same behavior as before 2026.1Beta.
Description of developer facing changes:

Restores a small Explorer app module overlay for File Explorer search band pane objects. The overlay suppresses redundant IAccessible focus events from Search Box and UniversalSearchBand pane objects.

Search Box has been confirmed on Windows 10. UniversalSearchBand is retained from the pre-#19117 filter because it appears to be another Explorer search band class, and the match is still limited to IAccessible pane objects.
Description of development approach:

This keeps the #19117 cleanup intact, except for the part that affected File Explorer search focus. The Windows 8 Start screen tile, group, launcher, and suggestion overlays are not restored.
@SaschaCowley SaschaCowley requested a review from a team as a code owner May 15, 2026 02:05
@SaschaCowley SaschaCowley requested a review from seanbudd May 15, 2026 02:05
@SaschaCowley SaschaCowley added this to the 2026.1.1 milestone May 15, 2026
@SaschaCowley SaschaCowley changed the title Fix File Explorer search box losing focus after Ctrl+F (#20022) Cherry-pick "Fix File Explorer search box losing focus after Ctrl+F (#20022)" to rc May 15, 2026
Comment thread user_docs/en/changes.md
@seanbudd seanbudd enabled auto-merge (squash) May 15, 2026 02:14
@seanbudd seanbudd merged commit 3a422bf into rc May 15, 2026
69 of 71 checks passed
@seanbudd seanbudd deleted the 20022-to-rc branch May 15, 2026 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants