Fix mistake in displayModel.DisplayModelTextInfo.getTextInChunks#7437
Merged
Conversation
…ere the wrong function name was used for super
Member
|
Out of interest, how did you find this bug? I.e. what is the practical use case that caused you to notice it? |
Collaborator
Author
|
@michaelDCurran commented on 24 jul. 2017 23:30 CEST:
I was trying to get the display model text word for word, but that failed |
michaelDCurran
approved these changes
Jul 25, 2017
Member
|
Merged straight to master as none of our code ever exercises this path, and it is really just a typo fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
In the getTextInChunks method on displayModel.DisplayModelTextInfo, a fallback with super is used for reading units other than line. However, the function tries to call _getTextInChunks on the super object, which does not exist.
Description of how this pull request fixes the issue:
Removes the leading underscore from the super(DisplayModelTextInfo,self).getTextInChunks call so that it actually succeeds.
Testing performed:
In Wordpad
Known issues with pull request:
None