Clarify wording in General Settings and spelling/spacing fixes#7726
Clarify wording in General Settings and spelling/spacing fixes#7726feerrenrut merged 8 commits intonvaccess:masterfrom
Conversation
…ing fixes. * Fixed various capitalization and spelling errors in docstrings and comments. * Clarified wording on some controls in NVDA settings dialogs. (fixes nvaccess#6344) * Fixed accelerator conflict between output device combobox and audio ducking checkbox in synthesizer settings dialog. * Added missing accelerators in document formatting, keyboard, object presentation, and review cursor settings dialogs. (Fixes nvaccess#6741) * Removed tabs from blank lines.
derekriemer
left a comment
derekriemer
left a comment
There was a problem hiding this comment.
Everything looks fine in this PR. I recommend a pass from NV Access, barring any other UI issues they find. It might be good to have someone sighted look over the GUI changes on this PR though. @ThomasStivers if you have a chance before it's reviewed by NV Access, I did note one thing you could take a stab at fixing.
source/gui/settingsDialogs.py
Outdated
|
|
||
| # Translators: The label for a setting in general settings to allow NVDA to start after logging onto Windows (if checked, NvDA will start automatically after loggin into Windows; if not, user must start NVDA by pressing the shortcut key (CTRL+Alt+N by default). | ||
| self.startAfterLogonCheckBox = wx.CheckBox(self, label=_("&Automatically start NVDA after I log on to Windows")) | ||
| # Translators: The label for a setting in general settings to allow NVDA to start after logging onto Windows (if checked, NvDA will start automatically after logging into Windows; if not, user must start NVDA by pressing the shortcut key (CTRL+Alt+N by default). |
There was a problem hiding this comment.
Please fix NVda while you're here.
|
Congrats on your first PR |
|
@derekriemer There is some outstanding discussion of these changes on the issue. Have you looked over #6344 ? |
|
@ThomasStivers: Could you please fix the merge conflicts and merge latest master into this? |
|
@feerrenrut is there anything else that needs to be done on this PR? |
|
Since there has been no activity in a while, I'm going to take this on:
|
This comment has been minimized.
This comment has been minimized.
|
@ThomasStivers Could you take a look at the diff / commit 91850e8 and let me know if you are happy with these changes? Then I can merge this. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Hi, Regression found: NVDA settings/Object Presentation/Guess object position has wrong accelerator, caused by two ampersand signs (a PR to resolve this is on its way). Thanks. |
#7726 caused a duplicate accelerator symbol for the 'guess object position information' checkbox
8 participants
Link to issue number:
Fixes #6344, #6741
Summary of the issue:
Known issues with pull request:
There are still controls in some preferences dialogs without accelerators.
Change log entry:
Added additional accelerator keys to preferences dialogs.