Handy Tech: Correct Bluetooth name for Braille Star 40 and fix gesture identifiers when braille input is on

[LeonarddeR]

Link to issue number:

None

Summary of the issue:

The new handy tech driver contained a wrong prefix for the Braille Star 40 braille display

Description of how this pull request fixes the issue:

@bramd fixed the prefix in his handytech-native branch. I created a new branch based on master and cherry-picked that commit. @bramd: For future work on the ht driver, it might be better to start with a new branch, based on master. :)

See also my comment below regarding the last minute fix for braille input gesture identifiers.

Change log entry:

Changes from rc1 to rc2:

• It is again possible to connect to Handy Tech Braille Star 40 devices using bluetooth
• Fixed an issue where overriding handy tech display gestures resulted into warnings about malformed input gesture identifiers.

[LeonarddeR]

@michaelDCurran: Please also merge this one into RC2 if possible, as it formally fixes a regression since 2017.3

[LeonarddeR]

Woops, another last minute fix. When braille input was on, malformed input gesture identifiers were generated. I caught this by checking the i/o log, I saw gestures like "br(handytech.modularevolution):" . That's right, without the ID. The identifiers will now be similar to braille input identifiers, e.g. br(handytech):dot1+dot2+dot7+space.

[bramd]

Thanks for the PR. I know starting a new branch for a PR is the best way to do this, but I was just testing this in a hurry over the weekend and one can always cherry-pick as you discovered :). Strictly, your fix for gesture identifiers is not really a regression, but it's a trivial fix and I would also gladly see it in 2017.4.

[LeonarddeR]

@bramd commented on 20 nov. 2017 19:58 CET:

Strictly, your fix for gesture identifiers is not really a regression,
but it's a trivial fix and I would also gladly see it in 2017.4.

It is a bug, but it's not live threatening if not included.
I just discovered that the current code is still not a complete fix. Let me do a quick test in two hours and commit something with complete testing performed this time.

[LeonarddeR]

Tested with all the keys on a Modular Evolution 88, including the left and right triple action keys and the keypad block.

[michaelDCurran]

For future reference, rc PRs should be based off of the RC branchh. However, as Master has not changed since, it is okay.