Revert "displayModel: second try at recording the actual background color for text when a transparant background color is set. (#7440)"#7803
Merged
michaelDCurran merged 1 commit intorcfrom Nov 29, 2017
Conversation
feerrenrut
approved these changes
Nov 29, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit edcf518.
This is a literal revert, no other code changes were made at all.
As reported in #7440, this again caused a significant performance hit in GDI-heavy applications. We must avoid using GetPixel. It is just too slow.
Once approved, this pr must be merged into rc before 2017.4.