Fix reading tables in LibreOffice (#8125) by catching NotImplementedE…#8126
Merged
michaelDCurran merged 1 commit intonvaccess:masterfrom Mar 28, 2018
Merged
Fix reading tables in LibreOffice (#8125) by catching NotImplementedE…#8126michaelDCurran merged 1 commit intonvaccess:masterfrom
michaelDCurran merged 1 commit intonvaccess:masterfrom
Conversation
…ementedError for row and column spans in compound documents
LeonarddeR
approved these changes
Mar 27, 2018
Collaborator
LeonarddeR
left a comment
LeonarddeR
left a comment
There was a problem hiding this comment.
Note that obj.rowNumber and obj.columnNumber could also raise a NotImplementedError. It might be a good idea to also catch exceptions for these? Would be good to know @michaelDCurran's opinion about that.
michaelDCurran
approved these changes
Mar 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix reading of tables in LibreOffice
Link to issue number:
Fixes #8125
Summary of the issue:
Tables don't read, but give an error sound.
Description of how this pull request fixes the issue:
Ignore row/column spans in compound documents if the implementation doesn't support them.
Testing performed:
Tested in LibreOffice.
Known issues with pull request:
None.
Change log entry:
None, since this is a regression from the previous release and doesn't have any user visible changes.