Update the Audacity appModule#8181
Merged
michaelDCurran merged 2 commits intonvaccess:masterfrom Jun 13, 2018
Merged
Conversation
In response to a request from the Audacity developers (issue nvaccess#8178). The workaround for buttons is no longer needed. However, the deletion of ampersand characters will be kept for the sake of backwards compatibility.
josephsl
previously requested changes
Apr 14, 2018
Contributor
josephsl
left a comment
josephsl
left a comment
There was a problem hiding this comment.
Apart from copyright header and a concern about old releases, I'm fine with this change, although we still need to do real-world testing at some point (by folks other than Robert). Thanks.
source/appModules/audacity.py
Outdated
| #appModules/audacity.py | ||
| #A part of NonVisual Desktop Access (NVDA) | ||
| #Copyright (C) 2006-2010 NVDA Contributors <http://www.nvda-project.org/> | ||
| #Copyright (C) 2006-2018 NVDA Contributors <https://www.nvaccess.org/> |
Contributor
There was a problem hiding this comment.
The updated copyright header should be:
Copyright (C) 2006-2018 NV Access Limited, yourname
Contributor
There was a problem hiding this comment.
Don't worry about hash sign.
|
|
||
| def event_NVDAObject_init(self,obj): | ||
| if obj.windowClassName=="Button" and not obj.role in [controlTypes.ROLE_MENUBAR, controlTypes.ROLE_MENUITEM, controlTypes.ROLE_POPUPMENU]: | ||
| obj.name=winUser.getWindowText(obj.windowHandle).replace('&','') |
Contributor
There was a problem hiding this comment.
What if someone using a really old version of Audacity decides to test this change?
Thanks.
Collaborator
There was a problem hiding this comment.
Same difference as if someone on XP decides to use NVDA. We no longer support them.
Contributor
Author
|
Thanks for reviewing Joseph.
I assume that you meant that the hash sign was interpreted as markdown.
I'm +1 for including the names of contributors in the header.
This allows to question them later in case of obscure code.
However, I have to change the encoding in order to do that.
Another nice thing would be that comments are signed with an author's
initials, e.g.
# rjh: This function should be removed for Python 3.7.0
I agree with Derek.
Those that use Audacity 1.3.x (All so called Betas) will most likely
use a NVDA version from ca. 2010 as well.
…On 14/04/2018, Derek Riemer ***@***.***> wrote:
derekriemer commented on this pull request.
> import controlTypes
class AppModule(appModuleHandler.AppModule):
def event_NVDAObject_init(self,obj):
if obj.windowClassName=="Button" and not obj.role in
[controlTypes.ROLE_MENUBAR, controlTypes.ROLE_MENUITEM,
controlTypes.ROLE_POPUPMENU]:
- obj.name=winUser.getWindowText(obj.windowHandle).replace('&','')
Same difference as if someone on XP decides to use NVDA. We no longer
support them.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#8181 (comment)
|
derekriemer
approved these changes
Apr 15, 2018
| #appModules/audacity.py | ||
| #A part of NonVisual Desktop Access (NVDA) | ||
| #Copyright (C) 2006-2010 NVDA Contributors <http://www.nvda-project.org/> | ||
| #Copyright (C) 2006-2018 NV Access Limited, Robert Hänggi |
Contributor
|
CC @feerrenrut
From: Derek Riemer <notifications@github.com>
Sent: Saturday, April 14, 2018 8:05 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Comment <comment@noreply.github.com>
Subject: Re: [nvaccess/nvda] Update the Audacity appModule (#8181)
@derekriemer approved this pull request.
_____
In source/appModules/audacity.py <#8181 (comment)> :
#appModules/audacity.py
#A part of NonVisual Desktop Access (NVDA)
-#Copyright (C) 2006-2010 NVDA Contributors <http://www.nvda-project.org/>
+#Copyright (C) 2006-2018 NV Access Limited, Robert Hänggi
Recommend incubate
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#8181 (review)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkEwK7WGFpvZpgbxmoDKcJ7WYSXYxks5torjDgaJpZM4TVNNH> .
|
feerrenrut
approved these changes
May 14, 2018
Contributor
feerrenrut
left a comment
feerrenrut
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
feerrenrut
added a commit
that referenced
this pull request
May 14, 2018
feerrenrut
dismissed
josephsl’s stale review
As stated in #8181 (review), the copyright header has been updated, and the concern about old releases has been addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
#8100 78
Summary of the issue:
In response to a request from the Audacity developers (issue #8178).
The workaround with window text for buttons is no longer needed.
Audacity versions that are released and still supported at the moment of this writing won't show a difference.
The upcoming 2.3.0 version, on the other hand, will greatly profit from the change.
Description of how this pull request fixes the issue:
As it should be, the IAccessible name is used instead of the window text.
The ampersand is however still replaced with an empty string.
This is only needed for older versions of WxWidgets.
Testing performed:
Yes, versions above 2.x.
Known issues with pull request:
None known.
Change log entry:
No visible change for the user.