Ensure spelling errors are still reported if IUIAutomationTextRange3 is unavailable#9180
Merged
michaelDCurran merged 1 commit intomasterfrom Jan 23, 2019
Merged
Ensure spelling errors are still reported if IUIAutomationTextRange3 is unavailable#9180michaelDCurran merged 1 commit intomasterfrom
michaelDCurran merged 1 commit intomasterfrom
Conversation
… still reported in UI Automation documents when IUIAutomationTextRange3 is not available.
LeonarddeR
approved these changes
Jan 22, 2019
Collaborator
LeonarddeR
left a comment
LeonarddeR
left a comment
There was a problem hiding this comment.
Looks good. However, I don't have an old Windows build to test this with.
Contributor
|
I've tested on the setup described in the #9176 and I can confirm that it is fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #9176
Summary of the issue:
Spelling errors are not being reported in speech or braille in early Windows 10 builds. This was seen when testing UIA in Microsoft Word 2016 by default.
Further testing showed that spelling errors, and other annotation information (such as comments) were not being reported, in any build of Windows before IUIAutomationTextRange3 was introduced, which allowed bulk fetching of text attributes.
The code that checked if annotationTypes should be fetched is incorrectly positioned within the block specific to IUIAutomationTextRange3.
Description of how this pull request fixes the issue:
This pr moves the config check to see if annotationTypes should be fetched, up so that this variable can be used whether IUIAutomationTextRange3 is available or not.
Testing performed:
Ensuring UIA was enabled, read a basic word document that contained some spelling errors, both on builds with IUIAutomationTextRange3 available and not available. In both cases spelling errors were properly reported.
Known issues with pull request:
None.
Change log entry:
None needed.