Make Developer scratchpad setting global #9265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o specific config profiles.
|
A simple list of all options, which are excluded from configuration profiles, in the User Guide should fix this confusion. |
LeonarddeR
approved these changes
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #9260
Summary of the issue:
The new Developer scratchpad setting is currently able to be configured for specific configuration profiles. This does not make sense for this setting and should be global like the settings in General and update etc.
Description of how this pull request fixes the issue:
the development config section is now included in the base-only sections, thus it will not paticipate in config profiles at all.
Testing performed:
Created a config profile and activated it.
Turned on developer scratchpad in the Advanced settings and saved configuration.
Restarted NVDA and ensured the config profile previously created was not in use.
Confirmed that the developer scratchpad setting was still switched on.
Known issues with pull request:
There could be a little confusion with the Advanced settings panel as now one of the options is global and the rest are config profile specific. I don't believe this is a big problem as I think it makes logical sense why this is. However, if there is a bit concirn from others, perhaps we should move this particular option to its own Development settings panel.
Change log entry:
None needed.