Added shift+enter and shift+numpadEnter keys to announce the reverse located cell in the same column in Excel

[abdel792]

Link to issue number:

Fixes #9499

Summary of the issue:

In the module 'NVDAObjects.window.excel.py', in the ExcelWorksheet class and more particularly, in the gestures parameter of the scriptHandler.script decorator, some gestures are missing.

When the user moves to the reverse located cell with shift + enter or shift + numpadEnter, no information is announced by NVDA, while the focus has moved to the reverse located cell (left, up, right or down, according to user's configuration in Excel).

Description of how this pull request fixes the issue:

This PR adds 2 gestures in the excel.py module mentioned above for NVDA to announce the reverse located cell:

• shift+enter;
• shift+numpadEnter.

Testing performed:

• Open Excel;
• In a sheet, move to cell B2 for example, with the arrow keys;
• Realize the gesture Shift+Enter or Shift+numpadEnter, the reverse located cell to which you have moved is announced.

Test performed on Office 2016, with Windows-10 version 1803.

Known issues with pull request:

None, but it may require further testing and opinion from developers and users.

Change log entry:

Section: Bug fixes

In Microsoft Excel, the user obtains the announcement of the reverse located cell when using the shift + enter and shift + numpadEnter gestures.

[Novalis7747]

thanks for that, I hope this gets merged soon.

[DrSooom]

@abdel792: Please see this wiki article regarding creating PRs.

[comanna]

Hi, I had not known of this behaviour in excel and found that, in fact, the message below is incorrect! Pressing the Enter key or Numpad Enter key in excel does not move forward to the next cell! I found the following behaviour while pressing Enter or Numpad Enter while in NVDA Focus Mode: I have installed the new NVDA 2019.1.1 on Windows 10 running Excel 2016. I find that hitting the Enter key while in Focus Mode moves back one row in the same column and shift and Enter does nothing. I also observe that hitting the Tab key moves to the next cell to the right and speaks it. However, pressing the Enter key again moves to the previous cell in the original column, as if I had never pressed Tab, and brings the active point back to that original column but in the previous row. Of course, when the Enter key has finally reached the first row, it just repeats the first cell without moving because there is now nowhere further backwards to go. I also found that when I hit the Tab key a few times after pressing the Enter key as described above, if I then press space, the active point moves to the new cell because it is now activated and now the Enter key escapes from the active cell and moves backwards through that new column. Here is a typical sequence to make this pattern clearer: 1. Arrow to cell E10 to begin the exercise; 2. Press the Enter key on the PC keyboard: – The pointer moves to E9 and speaks the cell coordinates and the contents if any; 3. Press the Tab key, say three times: The pointer moves to H9 and speaks coordinates and contents, if any; 4. Press the Enter key: the active pointer moves to E8 and speaks it in the usual way as if the Tab key had never been pressed; 5. Press Tab once: - NVDA now speaks F8; 6. Press Tab four more times: - The active point now moves to J8 and NVDA speaks the contents 7. Press the Enter key: - NVDA speaks the contents of cell E7 as if the Tab key had never been pressed; 8. Press the Tab key twice: - NVDA speaks the contents of cell G7; 9. Press Space to type a Space character in the cell: - NVDA announces “Edit item edit” cell G7 is now actively editing; 10. Press Enter: The active cursor moves to G6 and NVDA speaks the contents. It is clear that NVDA is not controlling this behaviour but it is interesting to observe what happens when these Excel keys are employed. All the best, Cearbhall m +353 (0)833323487 Ph: _353 (0)1-2864623 e: cearbhall.omeadhra@blbc.ie From: abdel792 <notifications@github.com> Sent: Monday, April 15, 2019 11:57 PM To: nvaccess/nvda <nvda@noreply.github.com> Cc: Subscribed <subscribed@noreply.github.com> Subject: [nvaccess/nvda] Added shift+Enter and shift+numpadEnter keys to announce the previous cell in the same column in Excel (#9497) * Added shift+Enter and shift+numpadEnter keys to announce the previous cell in the same column in Excel; * In principle, as the Enter and numpadEnter keys announce the next cell in the same column, the shift+Enter and shift+numpadEnter keys should announce the previous cell; * In fact, moving to previous or next cell is integrated by default in Excel, NVDA should just announce the current cell with each move.

…

_____ You can view, comment on, or merge this pull request online at: #9497 Commit Summary * * Added shift+Enter and shift+numpadEnter keys to announce the previous cell in the same column in Excel; File Changes * M source/NVDAObjects/window/excel.py <https://github.com/nvaccess/nvda/pull/9497/files#diff-0> (2) Patch Links: * https://github.com/nvaccess/nvda/pull/9497.patch * https://github.com/nvaccess/nvda/pull/9497.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, <#9497> view it on GitHub, or <https://github.com/notifications/unsubscribe-auth/AVWs8naH53qRoBYGZe42iTOpmLwMK0jZks5vhQOygaJpZM4cxCAH> mute the thread. <https://github.com/notifications/beacon/AVWs8vHxJz6BtFh46_FD0kjWat8LeA45ks5vhQOygaJpZM4cxCAH.gif>

[Novalis7747]

I can’t see what you are describing with latest Office 365 and with all Excel versions I had before. Pressing enter always moves 1 cell down and NVDA speaks the cell. Pressing shift-enter always moves 1 cell up in Excel, but NVDA don’t speak the cell, just as written in this PR. I have in-cell editing turned off in the excel options, maybe that’s makes a difference. From: comanna <notifications@github.com> Sent: Dienstag, 16. April 2019 12:24 To: nvaccess/nvda <nvda@noreply.github.com> Cc: Ralf Kefferpuetz <novalis7747@live.com>; Manual <manual@noreply.github.com> Subject: Re: [nvaccess/nvda] Added shift+enter and shift+numpadEnter keys to announce the previous cell in the same column in Excel (#9497) Hi, I had not known of this behaviour in excel and found that, in fact, the message below is incorrect! Pressing the Enter key or Numpad Enter key in excel does not move forward to the next cell! I found the following behaviour while pressing Enter or Numpad Enter while in NVDA Focus Mode: I have installed the new NVDA 2019.1.1 on Windows 10 running Excel 2016. I find that hitting the Enter key while in Focus Mode moves back one row in the same column and shift and Enter does nothing. I also observe that hitting the Tab key moves to the next cell to the right and speaks it. However, pressing the Enter key again moves to the previous cell in the original column, as if I had never pressed Tab, and brings the active point back to that original column but in the previous row. Of course, when the Enter key has finally reached the first row, it just repeats the first cell without moving because there is now nowhere further backwards to go. I also found that when I hit the Tab key a few times after pressing the Enter key as described above, if I then press space, the active point moves to the new cell because it is now activated and now the Enter key escapes from the active cell and moves backwards through that new column. Here is a typical sequence to make this pattern clearer: 1. Arrow to cell E10 to begin the exercise; 2. Press the Enter key on the PC keyboard: – The pointer moves to E9 and speaks the cell coordinates and the contents if any; 3. Press the Tab key, say three times: The pointer moves to H9 and speaks coordinates and contents, if any; 4. Press the Enter key: the active pointer moves to E8 and speaks it in the usual way as if the Tab key had never been pressed; 5. Press Tab once: - NVDA now speaks F8; 6. Press Tab four more times: - The active point now moves to J8 and NVDA speaks the contents 7. Press the Enter key: - NVDA speaks the contents of cell E7 as if the Tab key had never been pressed; 8. Press the Tab key twice: - NVDA speaks the contents of cell G7; 9. Press Space to type a Space character in the cell: - NVDA announces “Edit item edit” cell G7 is now actively editing; 10. Press Enter: The active cursor moves to G6 and NVDA speaks the contents. It is clear that NVDA is not controlling this behaviour but it is interesting to observe what happens when these Excel keys are employed. All the best, Cearbhall m +353 (0)833323487 Ph: _353 (0)1-2864623 e: cearbhall.omeadhra@blbc.ie<mailto:cearbhall.omeadhra@blbc.ie> From: abdel792 <notifications@github.com<mailto:notifications@github.com>> Sent: Monday, April 15, 2019 11:57 PM To: nvaccess/nvda <nvda@noreply.github.com<mailto:nvda@noreply.github.com>> Cc: Subscribed <subscribed@noreply.github.com<mailto:subscribed@noreply.github.com>> Subject: [nvaccess/nvda] Added shift+Enter and shift+numpadEnter keys to announce the previous cell in the same column in Excel (#9497) * Added shift+Enter and shift+numpadEnter keys to announce the previous cell in the same column in Excel; * In principle, as the Enter and numpadEnter keys announce the next cell in the same column, the shift+Enter and shift+numpadEnter keys should announce the previous cell; * In fact, moving to previous or next cell is integrated by default in Excel, NVDA should just announce the current cell with each move.

…

_____ You can view, comment on, or merge this pull request online at: #9497 Commit Summary * * Added shift+Enter and shift+numpadEnter keys to announce the previous cell in the same column in Excel; File Changes * M source/NVDAObjects/window/excel.py <https://github.com/nvaccess/nvda/pull/9497/files#diff-0> (2) Patch Links: * https://github.com/nvaccess/nvda/pull/9497.patch * https://github.com/nvaccess/nvda/pull/9497.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, <#9497> view it on GitHub, or <https://github.com/notifications/unsubscribe-auth/AVWs8naH53qRoBYGZe42iTOpmLwMK0jZks5vhQOygaJpZM4cxCAH> mute the thread. <https://github.com/notifications/beacon/AVWs8vHxJz6BtFh46_FD0kjWat8LeA45ks5vhQOygaJpZM4cxCAH.gif> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnvaccess%2Fnvda%2Fpull%2F9497%23issuecomment-483602267&data=02%7C01%7C%7Cafbe2e2801f44ec9fa4608d6c255a4fa%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636910070422239288&sdata=JbnCML7XL%2BXrIDkOf%2BQeFe5jOU3SDQEccoAiLdtbThI%3D&reserved=0>, or mute the thread<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAffwnPbj3__dz8IdNJDjKMshiAjGJoTlks5vhaTBgaJpZM4cxCAH&data=02%7C01%7C%7Cafbe2e2801f44ec9fa4608d6c255a4fa%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636910070422259304&sdata=CvCveoqp6v7f8Fgo0DFd6ay%2BzJjFRAK1NaBO30JYdXI%3D&reserved=0>.

[DrSooom]

Microsoft Excel 2010 » Options » Advanced » Move selection after pressing the Enter key (enabled by default) and its direction (down by default). Shift+Enter reverses the direction.

[abdel792]

Hi,
@DrSooom:

Thank you, I followed the instructions described in the Wiki before creating this PR, I chose the draft type.

@comanna:

Thanks for the explanations, there is just a small detail:

Here, with Office 2016 and earlier versions, Enter moves a cell down, not up, as @Novalis7747 said.

Kind regards.

[comanna]

Hi, The option to move down to the next cell or back to the previous cell is set in Options under “Advanced”. I was mistaken to assert that the earlier message was wrong, my apologies! All the best, Cearbhall m +353 (0)833323487 Ph: _353 (0)1-2864623 e: cearbhall.omeadhra@blbc.ie From: abdel792 <notifications@github.com> Sent: Tuesday, April 16, 2019 12:33 PM To: nvaccess/nvda <nvda@noreply.github.com> Cc: comanna <cearbhall.omeadhra@blbc.ie>; Mention <mention@noreply.github.com> Subject: Re: [nvaccess/nvda] Added shift+enter and shift+numpadEnter keys to announce the previous cell in the same column in Excel (#9497) Hi, @DrSooom <https://github.com/DrSooom> : Thank you, I followed the instructions described in the Wiki <https://github.com/nvaccess/nvda/wiki/Github-pull-request-template-explanation-and-examples> before creating this PR, I chose the draft type. @comanna <https://github.com/comanna> : Thanks for the explanations, there is just a small detail: Here, with Office 2016 and earlier versions, Enter moves a cell down, not up, as @Novalis7747 <https://github.com/Novalis7747> said. Kind regards. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9497 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AVWs8pczoyumeosOxwnYwfmE9rTFkyroks5vhbTdgaJpZM4cxCAH> . <https://github.com/notifications/beacon/AVWs8rr5-GRL0HoKt31kgnF5fY4hFihQks5vhbTdgaJpZM4cxCAH.gif>

[abdel792]

@comanna:

No problem.

Your explanations about the action of Enter key after moving with tab are very useful, I didn't know that.

Kind regards.

[comanna]

Thanks for the clarification, I am glad to hear that the explanation is useful. All the best, Cearbhall m +353 (0)833323487 Ph: _353 (0)1-2864623 e: cearbhall.omeadhra@blbc.ie From: abdel792 <notifications@github.com> Sent: Tuesday, April 16, 2019 3:37 PM To: nvaccess/nvda <nvda@noreply.github.com> Cc: comanna <cearbhall.omeadhra@blbc.ie>; Mention <mention@noreply.github.com> Subject: Re: [nvaccess/nvda] Added shift+enter and shift+numpadEnter keys to announce the previous cell in the same column in Excel (#9497) @comanna <https://github.com/comanna> : No problem. Your explanations about the action of Enter key after moving with tab are very useful, I didn't know that. Kind regards. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9497 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AVWs8va82vkZxfP3mp-zCeZ3KxWTNE-qks5vhd_ygaJpZM4cxCAH> . <https://github.com/notifications/beacon/AVWs8hI15qxqGobJOQNj71PKPguhinlwks5vhd_ygaJpZM4cxCAH.gif>

[DrSooom]

The user obtains the announcement of the cell located a line above when using the shift + enter and shift + numpadEnter gestures.

As the direction can be set by the user – as I mentioned before –, this sentence isn't fully correct.

The user obtains the announcement of the reverse located cell on pressing Shift+Enter and Shift+NumpadEnter in Microsoft Excel.

[abdel792]

@DrSooom:

Thank you, you're right, I just corrected that.

I hope this PR will be merged very soon.

Kind regards.

[DrSooom]

The user obtains the announcement of the reverse located cell when using the shift + enter and shift + numpadEnter gestures.

This PR is limited to Microsoft Excel. Therefore please add this information to the changelog entry as well. Thanks.

Interesting: These hotkeys already works as expected in LibreOffice Calc 6.2.3.2 with NVDA 2018.1. And here you can change their directions in the options too like in Microsoft Excel. (I know that the AppModule "soffice" is used for LibreOffice, but I just wanted to note this down. So, it's very nice to get this feedback now in Microsoft Excel as well.)

[abdel792]

@LeonarddeR:

Thanks a lot for your approval, I'll be very happy to see this change in the 2019.2 version of NVDA.

@DrSooom:

Thanks for this detail, I just corrected the Change log entry.

Kind regards.

[feerrenrut]

Looks good to me. I have tested this in Excel 2013, it works as expected.

[feerrenrut]

In the testing performed section, please mention the versions of office / windows.

[abdel792]

Thanks @feerrenrut,

I just updated the Testing performed section.

Kind regards.