Update espeak-ng to latest master#9668
Merged
Merged
Conversation
michaelDCurran
force-pushed
the
updateEspeak
branch
from
1c8b969 to
b8cc558
Compare
feerrenrut
approved these changes
Jun 5, 2019
Contributor
feerrenrut
left a comment
feerrenrut
left a comment
There was a problem hiding this comment.
I think it's worth asking on the dev list for feedback on whether this introduces issues in other languages after it is merged.
Contributor
|
Hi @feerenrut,
My opinion is to merge this instantly, and then ask a feedback from the alpha snapshot users, or please create a try build
And i will test it
From: Reef Turner <notifications@github.com>
Sent: Wednesday, June 5, 2019 6:39 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: Re: [nvaccess/nvda] Update espeak-ng to latest master (#9668)
@feerrenrut approved this pull request.
I think it's worth asking on the dev list for feedback on whether this introduces issues in other languages after it is merged.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#9668?email_source=notifications&email_token=ACVCDE6GXNYD2T5IL2HLDP3PY7T2LA5CNFSM4HTFVYK2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2VZJRQ#pullrequestreview-246125766> , or mute the thread <https://github.com/notifications/unsubscribe-auth/ACVCDE5BI5AKHRAE45EE4QLPY7T2LANCNFSM4HTFVYKQ> . <https://github.com/notifications/beacon/ACVCDE733Q6WZBAJ6INB6OTPY7T2LA5CNFSM4HTFVYK2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2VZJRQ.gif>
|
|
@michaelDCurran: Isn't this PR closing issue #9532? (I didn't take a deeper look into this.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None.
Summary of the issue:
eSpeak-ng in NVDA is at least 6 months old now. We should upgrade to latest eSpeak-ng master.
Description of how this pull request fixes the issue:
Updates espeak-ng to commit 86e67a.
Testing performed:
Ran NVDA and used eSpeak for several minutes in English.
Known issues with pull request:
None.
Change log entry:
Changes:
Updated espeak to commit 86e67a.