Python 3: more native imports and modules#9751
Merged
michaelDCurran merged 4 commits intonvaccess:threshold_py3_stagingfrom Jun 16, 2019
Merged
Python 3: more native imports and modules#9751michaelDCurran merged 4 commits intonvaccess:threshold_py3_stagingfrom
michaelDCurran merged 4 commits intonvaccess:threshold_py3_stagingfrom
Conversation
michaelDCurran
approved these changes
Jun 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
There are more modules that could see Python 3 native import.
Description of how this pull request fixes the issue:
Deferred from @michaelDCurran's native imports work:
Steps:
Testing performed:
Tested with both Python 2 and 3 versions of NVDA, along with Python interpreters.
Known issues with pull request:
None
Change log entry:
None
Additional context:
There might be more modules that are not seeing Python 3 native imports. Also, there might be modules that are imported but are not used at all e.g. io.StringIO is imported from config main module but isn't used.