Remove usage of cmp function#9758
Merged
michaelDCurran merged 1 commit intothreshold_py3_stagingfrom Jun 16, 2019
Merged
Conversation
josephsl
approved these changes
Jun 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None.
Summary of the issue:
the cmp function no longer exists in Python3.
Description of how this pull request fixes the issue:
Replace all usage of cmp with the recommended equivilant from the Python 3.0 what's new document: I.e.
This works as the bools returned from the comparison operators are coerced to ints (0 for False and 1 for True) when performing the subtraction.
Testing performed:
NVDA no longer comaplsins about cmp being missing when using compoundDocuments (E.g. in Gecko editable documents).
NVDA no longer fails to show the installation dialog after pressing the Install button in the NVDA launcher.
Known issues with pull request:
None.
Change log entry:
None.
Section: New features, Changes, Bug fixes