Fix waiting for outlook/powerpoint window to exist for ever#9950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #9921
Summary of the issue:
In outlook and powerpoint, we create a waiting for xx window while pumping com events. However, comtypes.client.PumpEvents now always raises an error due to a bug in comtypes, see enthought/comtypes#187
Description of how this pull request fixes the issue:
As PumpEvents can also raise an error in other cases than a time out, I decided to wrap PumpEvents into a try except and log the exception. Until t the bug is fixed in comtypes, this will also log a debug warning for time outs, though that's not very problematic IMO.
Testing performed:
T.b.d. not very easy to reproduce the bug.
Known issues with pull request:
Still a bug in comtypes, with an open pr to fix it.
Change log entry:
None