Open
Conversation
Exposed APIs for global menubar on Ubuntu. This patch also removed global menubar for DevTools window. fixed partially on nwjs/nw.js#2718
rogerwang
pushed a commit
that referenced
this pull request
Sep 7, 2016
The code stays around for now, so we can turn it on via a variation param if required. BUG=640566 Review-Url: https://codereview.chromium.org/2279273002 Cr-Commit-Position: refs/heads/master@{#414703} (cherry picked from commit 6a34d5d) Review URL: https://codereview.chromium.org/2295773002 . Cr-Commit-Position: refs/branch-heads/2840@{#39} Cr-Branched-From: 1ae106d-refs/heads/master@{#414607}
rogerwang
pushed a commit
that referenced
this pull request
Dec 5, 2016
This is still not handling view resizes that happen when an ink drop is active (e.g., in status tray). A workaround is implemented, but proper fix would need a follow-up CL. This CL also changes round rect mask to take insets instead of bounds so that there would be no need to update mask bounds when size of host view is updated. BUG=612544 TEST=manual Review-Url: https://codereview.chromium.org/2510603003 Cr-Commit-Position: refs/heads/master@{#433113} (cherry picked from commit c109436) Review URL: https://codereview.chromium.org/2523523002 . Cr-Commit-Position: refs/branch-heads/2924@{#39} Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}
GnorTech
pushed a commit
that referenced
this pull request
Jan 29, 2017
Not all areas of Chrome handle single cancelled touches well, to improve palm suppression support, we will cancel all touches if a single touch was reported as cancelled by the touch device. No further events are coming through until the touches are released. BUG=chrome-os-partner:60780 TEST=None NOPRESUBMIT=true NOTRY=true Review-Url: https://codereview.chromium.org/2640163003 Cr-Commit-Position: refs/heads/master@{#445126} (cherry picked from commit ab976a7) Review-Url: https://codereview.chromium.org/2653783002 Cr-Commit-Position: refs/branch-heads/2987@{#39} Cr-Branched-From: ad51088-refs/heads/master@{#444943}
rogerwang
pushed a commit
that referenced
this pull request
Mar 11, 2017
BUG=697837, 698726 Review-Url: https://codereview.chromium.org/2732993002 Cr-Commit-Position: refs/heads/master@{#454861} (cherry picked from commit 70079b5) Review-Url: https://codereview.chromium.org/2736893002 . Cr-Commit-Position: refs/branch-heads/3029@{#39} Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
GnorTech
pushed a commit
that referenced
this pull request
Apr 26, 2017
Move the highlight int to an Integer to allow null. This allows 0 to be a valid id, which it turns out is the case in CCTs. BUG=711523 Review-Url: https://codereview.chromium.org/2814243004 Cr-Commit-Position: refs/heads/master@{#464996} (cherry picked from commit 13b8f41) Review-Url: https://codereview.chromium.org/2822293003 . Cr-Commit-Position: refs/branch-heads/3071@{#39} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
GnorTech
pushed a commit
that referenced
this pull request
Aug 5, 2017
Previously, when a scan began, we would clear all existing scan results from the cache, then add results back to the cache as the scan progressed. This was janky because it would result in the UI removing Tether networks and then adding them back shortly afterwards when scan results came in. This CL changes this functionality so that results are only removed after a scan ends and the associated device is not found. TBR=khorimoto@google.com (cherry picked from commit 7830751) Bug: 672263, 746726 Change-Id: I6df2516b1bc0e604c3a496838804bc6ee5c8292c Reviewed-on: https://chromium-review.googlesource.com/581633 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#488817} Reviewed-on: https://chromium-review.googlesource.com/584862 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#39} Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech
pushed a commit
that referenced
this pull request
Sep 14, 2017
See design doc: https://docs.google.com/document/d/10eGUww_2Ufv-YyGwnmr9ke_89Q6By_94v02FM_NTU24 The main logic was introduced in https://chromium-review.googlesource.com/c/chromium/src/+/625496 TBR=claudiomagni@chromium.org (cherry picked from commit 6ddc1c3) Bug: 737232 Change-Id: I8f22cbba99a571edc1f95248ebb6ba8b5806d535 Reviewed-on: https://chromium-review.googlesource.com/647047 Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org> Commit-Queue: Claudio M <claudiomagni@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499388} Reviewed-on: https://chromium-review.googlesource.com/651669 Reviewed-by: Marti Wong <martiw@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#39} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech
pushed a commit
that referenced
this pull request
Oct 27, 2017
There's a race condition when event listener feedbackPrivate.onFeedbackRequested is added before feedback dialog extension is loaded completely. The CL prevents this by sending request to the extension only after the extension is loaded. BUG=754329,764997 TEST=LoginFeedbackTest.Basic with flag --enable-browser-side-navigation TBR=afakhry@chromium.org (cherry picked from commit b0df035) Change-Id: I2988012d91dd3bd61e1a27ab2486a603e1e0fa64 Reviewed-on: https://chromium-review.googlesource.com/722027 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#509246} Reviewed-on: https://chromium-review.googlesource.com/724206 Cr-Commit-Position: refs/branch-heads/3239@{#39} Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang
pushed a commit
that referenced
this pull request
Jan 29, 2018
The Bluetooth APIs accept callback and error callback parameters when sending a message, but we've recently discovered that there are some bugs which can prevent these callbacks from being invoked. This CL adds an extra timeout which ensures that even if the callbacks are not invoked, BluetoothLowEnergyWeaveClientConnection handles this case robustly. This is not the full fix to https://crbug.com/803677, but it is a partial fix which can avoid some nasty side effects for Instant Tethering. TBR=khorimoto@google.com (cherry picked from commit fe22dec) Bug: 803677, 672263 Change-Id: I982c08dfe726a3c3e3164aac87ca8bec10b68be7 Reviewed-on: https://chromium-review.googlesource.com/877339 Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#531062} Reviewed-on: https://chromium-review.googlesource.com/882216 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#39} Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech
pushed a commit
that referenced
this pull request
Mar 20, 2018
This Cl doesn't include the bindings, only the UI. TBR=alemate@chromium.org (cherry picked from commit 3eaeb8c) Bug: 818366 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4d07d68700e60e31a1b1260b48ea40c511c27be3 Reviewed-on: https://chromium-review.googlesource.com/947567 Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#540734} Reviewed-on: https://chromium-review.googlesource.com/952102 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#39} Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang
pushed a commit
that referenced
this pull request
Apr 25, 2018
This CL records the user actions:
* Signin_Impression_FromAvatarBubbleSignin.
* Signin_Impression{With|No}Account_FromAvatarBubbleSignin
Bug: 819432
Change-Id: Ica6334eb9fbe63ed9db285379095d7a5613b4370
Reviewed-on: https://chromium-review.googlesource.com/1007442
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550613}(cherry picked from commit 20e0c79)
Reviewed-on: https://chromium-review.googlesource.com/1012851
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#39}
Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang
pushed a commit
that referenced
this pull request
Jun 19, 2018
R=cmasso@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2b67c01e26107f1141ffaf51255b48ee4e10934a Reviewed-on: https://chromium-review.googlesource.com/1077683 Reviewed-by: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#39} Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech
pushed a commit
that referenced
this pull request
Aug 4, 2018
… overflow" This reverts commit 6ea2a2e. Reason for revert: crbug.com/866109 Original change's description: > [css-text] A leading white-space should break before handling overflow > > Leading white-spaces are indeed breaking opportunities that should > prevent, if there are no other css properties forcing it, breaking text > in the middle of a word when honoring the word-wrap/overflow-wrap CSS > property. > > We are doing so if the leading white-space sequence is longer than 1 > character, but when we have a single leading white-space, we are missing > that breaking opportunity and we may lead to cases, like the one > described in the bug. > > However, this breaking opportunity should be considered together > with other provided by the word-break CSS property (eg, break-word or > break-all). > > There is a discussion [1] in the CSS WG github about this issue, which > provides an interoperability analysis of a few cases where a single > leading white-space character may produce different results, depending > on the browser and the combination of line-breaking properties. > > [1] w3c/csswg-drafts#2907 > > Bug: 854624 > Change-Id: I49ec8282e899a32990662c104b48cab04057b909 > Reviewed-on: https://chromium-review.googlesource.com/1130515 > Commit-Queue: Javier Fernandez <jfernandez@igalia.com> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575596} TBR=jfernandez@igalia.com,kojii@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 854624, 866109 Change-Id: I9ee4cd370dd92b74f9fdc4f42d16638253dd2dee Reviewed-on: https://chromium-review.googlesource.com/1146360 Reviewed-by: Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Original-Commit-Position: refs/heads/master@{#577096}(cherry picked from commit 04c10b7) Reviewed-on: https://chromium-review.googlesource.com/1148520 Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#39} Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang
pushed a commit
that referenced
this pull request
Sep 15, 2018
TBR=govind@chromium.org Change-Id: I764ec535f3a5a6918725b94e57f624a3facf741f Reviewed-on: https://chromium-review.googlesource.com/1205716 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#39} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang
pushed a commit
that referenced
this pull request
Oct 31, 2018
Before this patch, launching a Payment Handler CCT would show a black patch on device bottom keys. The keys were still there, but the foreground and background were the same color. This happened only on Oreo and Pie. Nougat and earlier versions continued to work OK. This patch disables windowLightNavigationBar in the style of the DimmingDialog, which dims the background behind the Payment Handler CCT. This property is available in API versions 28 and higher. After this patch, launching a Payment Handler CCT shows the navbar buttons. TBR=rouslan@chromium.org (cherry picked from commit f8d653a) Bug: 890183 Change-Id: I42126f434f928f80355c849c3a2fd3d1e6e85b13 Reviewed-on: https://chromium-review.googlesource.com/c/1259364 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Peter Conn <peconn@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599550} Reviewed-on: https://chromium-review.googlesource.com/c/1283473 Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#39} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang
pushed a commit
that referenced
this pull request
Dec 18, 2018
This CL is kept minimal to facilitate merge to M72 (and potentially M71). Details on comments 14 and 15 on https://crbug.com/910274 A more complete solution addressing SkiaRenderer,SkDDL will come when issue 902904 is resolved. Bug: 910274 Change-Id: Ie0f44443fa30a5ec87045bd138a3a8a08e17e35c Reviewed-on: https://chromium-review.googlesource.com/c/1358799 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#613173}(cherry picked from commit 7de4ba6) Reviewed-on: https://chromium-review.googlesource.com/c/1362002 Reviewed-by: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#39} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang
pushed a commit
that referenced
this pull request
Feb 10, 2019
R=cmasso@chromium.org Change-Id: I6796b7896d954043cdad4e780e49f212e2bd3adc Reviewed-on: https://chromium-review.googlesource.com/c/1443518 Reviewed-by: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/branch-heads/3683@{#39} Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang
pushed a commit
that referenced
this pull request
Mar 24, 2019
Bug: 934125 Change-Id: Id2682fec9a84a495b3269d90173fd6e28e2b89fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503573 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Cr-Original-Commit-Position: refs/heads/master@{#639101}(cherry picked from commit 5f7d82d0c4d7ecd39a7ab983d7a931f80d41bcca) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517905 Reviewed-by: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/branch-heads/3729@{#39} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposed APIs for global menubar on Ubuntu. This patch also removed
global menubar for DevTools window.
fixed partially on nwjs/nw.js#2718
backport for NW14