[59706] Replace deprecated 'request' library (Rebased)#234
Merged
mrashed-dev merged 3 commits intomainfrom May 31, 2021
Merged
Conversation
The test cases were using the `requests` library that was removed in the previous commit. Now they are updated to use the new `node-fetch` library.
AaronDDM
approved these changes
May 31, 2021
Merged
mrashed-dev
added a commit
that referenced
this pull request
Jun 9, 2021
New `nylas` v5.5.0 release bringing in the following new features: * Replaced deprecated `request` library with `node-fetch` (#234) * Add custom error class `NylasApiError` to add more error details returned from the API (#236) * Add support for read only fields (#237) * Enabled Nylas API v2.2 support (#237) The new release also fixes the following: * Fix bug where saving a `draft` object with an undefined `filesIds` would throw an error (#230) * Fix typings for classes that extend `RestfulModelCollection` or `RestfulModelInstance` (#238)
Contributor
|
@mrashed-dev Looks like |
TrySound
added a commit
to TrySound/nylas-nodejs
that referenced
this pull request
Jun 10, 2021
Request package was left in dependencies here nylas#234
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
requestslibrary has been deprecated for a while now. We've since moved on tonode-fetchas it's supported elsewhere in the SDK. Test suite has been updated as well to make sure that we don't fail because of this change.Please see #233 for reviewer comments.
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.