[59076] Add read only fields and enable v2.2 API support#237
Merged
mrashed-dev merged 12 commits intomainfrom Jun 8, 2021
Merged
[59076] Add read only fields and enable v2.2 API support#237mrashed-dev merged 12 commits intomainfrom
mrashed-dev merged 12 commits intomainfrom
Conversation
v2.2 just entails adding some extra read-only fields to the room resource object
This attribute is false by default. When invoking `toJSON` for sending a payload to the Nylas API, only the non-readonly attributes will be sent.
Part of the v2.2 update
|
This pull request has been linked to Clubhouse Story #59076: Add read-only fields to Node SDK. |
if `enforceReadOnly` is false it should bypass the `Attribute.readOnly` check
We no longer send read only variables such as id, object and account_id in our requests to the API
AaronDDM
reviewed
Jun 8, 2021
AaronDDM
approved these changes
Jun 8, 2021
As a result of bubbling up `enforceReadOnly` value
AaronDDM
approved these changes
Jun 8, 2021
mrashed-dev
deleted the
mostafarashed/ch59076/add-read-only-fields-to-node-sdk
branch
Merged
mrashed-dev
added a commit
that referenced
this pull request
Jun 9, 2021
New `nylas` v5.5.0 release bringing in the following new features: * Replaced deprecated `request` library with `node-fetch` (#234) * Add custom error class `NylasApiError` to add more error details returned from the API (#236) * Add support for read only fields (#237) * Enabled Nylas API v2.2 support (#237) The new release also fixes the following: * Fix bug where saving a `draft` object with an undefined `filesIds` would throw an error (#230) * Fix typings for classes that extend `RestfulModelCollection` or `RestfulModelInstance` (#238)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR was spawned by the need to add new read-only fields to the Room Resource object. We did not have support for read-only objects yet in this SDK, so this PR achieves the following:
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.