[61828] Fix typing for classes that extend RestfulModelCollection or RestfulModelInstance#238
Merged
mrashed-dev merged 3 commits intomainfrom Jun 9, 2021
Conversation
The `RestfulModelCollection` implementation for `Contact` and `Calendar` were returning a generic `RestfulModelCollection` instead of the proper requested type
`RestfulModelInstance` was returning a generic type instead of specific types. This was causing `nylas.with().account.get()` to return a generic type instead of an `Account` type
|
This pull request has been linked to Clubhouse Story #61828: Node sdk type script for calendar. |
This was
linked to
issues
Jun 8, 2021
AaronDDM
approved these changes
Jun 9, 2021
This was referenced Jun 9, 2021
Merged
mrashed-dev
added a commit
that referenced
this pull request
Jun 9, 2021
New `nylas` v5.5.0 release bringing in the following new features: * Replaced deprecated `request` library with `node-fetch` (#234) * Add custom error class `NylasApiError` to add more error details returned from the API (#236) * Add support for read only fields (#237) * Enabled Nylas API v2.2 support (#237) The new release also fixes the following: * Fix bug where saving a `draft` object with an undefined `filesIds` would throw an error (#230) * Fix typings for classes that extend `RestfulModelCollection` or `RestfulModelInstance` (#238)
agtang96
deleted the
mostafarashed/ch61828/node-sdk-type-script-for-calendar
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some classes were returning a generic type, rendering some calls and functionality useless. This PR aims at fixing this by properly setting the type of objects that that extend
RestfulModelCollectionorRestfulModelInstanceto provide the user access to type-specific properties and methods.License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.