Skip to content

Feature/validator api client endpoints#1024

Merged
jstuczyn merged 10 commits into
developfrom
feature/validator-api-client-endpoints
Jan 11, 2022
Merged

Feature/validator api client endpoints#1024
jstuczyn merged 10 commits into
developfrom
feature/validator-api-client-endpoints

Conversation

@jstuczyn

Copy link
Copy Markdown
Contributor

It depends on #1019 and thus remains as a draft until the aforementioned PR is merged.

@jstuczyn jstuczyn force-pushed the feature/validator-api-client-endpoints branch from daadae0 to 6978024 Compare January 11, 2022 09:39
@jstuczyn jstuczyn marked this pull request as ready for review January 11, 2022 10:13

@mmsinclair mmsinclair left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - only a couple of questions about the typescript feature flag

Comment thread nym-wallet/src-tauri/Cargo.toml
Comment thread validator-api/validator-api-requests/src/models.rs
Comment thread common/client-libs/validator-client/src/validator_api/mod.rs Outdated
@jstuczyn jstuczyn merged commit e2e06df into develop Jan 11, 2022
@jstuczyn jstuczyn deleted the feature/validator-api-client-endpoints branch January 11, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants