Skip to content

[finding] Comments across the repo still call 17.0.0-rc.6 "the pinned" @objectstack/spec — no package.json declares that range any more #6925

Description

@os-sam

Found while implementing the prose-only header fix for #5881 (branch claude/issue-5881-record-highlights-header-prose). Reported rather than fixed: that card is fenced to one file's module header, and this is a repo-wide pattern.

The claim

Several live source/test comments narrate 17.0.0-rc.6 in the present tense, as the version this repo is pinned to. Measured on e3d117ae1:

$ git grep '17\.0\.0-rc\.6' -- '*.json'
(no output — exit 0, zero matches)

$ node -e "console.log(require('./node_modules/@objectstack/spec/package.json').version)"
17.2.0

Positive control that the grep channel reads at all, same run, same tree:

$ git grep -c 'specRefusesUnknownTopLevelKeys' -- 'packages/plugin-detail/**'
packages/plugin-detail/src/__tests__/recordDetailsInputs.spec-parity.test.ts:1
packages/plugin-detail/src/__tests__/recordHighlightsInputs.spec-parity.test.ts:4
packages/plugin-detail/src/__tests__/recordRelatedListInputs.spec-parity.test.ts:1

So no manifest in the workspace declares 17.0.0-rc.6, and the installed spec is 17.2.0. Every dependency range that matched was ^17.0.0 or ^17.1.0.

Where it reads as current fact

git grep -n -i 'pinned[^.]\{0,40\}17\.0\.0-rc\.6\|17\.0\.0-rc\.6[^.]\{0,20\}pin' -- 'packages/**' 'apps/**' returns 11 files. Excluding CHANGELOGs (those are historical records and are correct as written), the live ones:

  • apps/console/src/__tests__/registry-inputs-spec-parity.test.ts:404 — "ComponentPropsMap and the pinned 17.0.0-rc.6 does not carry at all"
  • packages/app-shell/src/__tests__/spec-symbol-parity.test.ts:172 — "which this repo is not pinned to yet (^17.0.0-rc.6; chore: raise the @objectstack/spec pin from ^17.0.0-rc.6 to 17.0.0 GA (lockfile resolution + green-keeping adaptations) #4636 / PR chore(deps): raise the @objectstack/* pin from ^17.0.0-rc.6 to 17.0.0 GA #4639 raises …)"
  • packages/plugin-grid/src/__tests__/spec-symbol-4650.test.ts:47 — "repo is pinned to ^17.0.0-rc.6, which does not export that name yet"
  • packages/plugin-detail/src/__tests__/recordDetailsInputs.spec-parity.test.ts:122 — "the pinned 17.0.0-rc.6 strips"
  • packages/plugin-detail/src/__tests__/recordHighlightsInputs.spec-parity.test.ts:81 — "the pinned 17.0.0-rc.6 still strips it silently"
  • apps/console/src/__tests__/component-input-union-specimens.test.ts:311 — past tense already ("was measured at the 17.0.0-rc.6 pin"), listed only so the sweep's boundary is legible; it is arguably already correct.

Severity, honestly

Low, and no assertion is affected: the two spec-parity instances sit beside behavioural probes (specRefusesUnknownTopLevelKeys) that read the installed pin at runtime, so the tests stay correct whichever way the pin answers. The harm is the same one #4918 and #5881 were filed for — a comment that reads as current to the next agent and is not, in a file the repo points other tests at as the reference shape. Two of the instances state a capability as absent ("does not export that name yet", "does not carry at all") that a later pin may well have added, which is the direction that misleads hardest.

Suggested disposition

Prose-only, one sweep, same disposition as PR #5879 and #5881: put the version claims in the past tense as a historical contrast, or drop the version entirely and point at the behavioural probe. ⚠️ Two of the named files are recordDetailsInputs.spec-parity.test.ts and recordRelatedListInputs.spec-parity.test.ts, which #5887 is editing — sequence against it rather than in parallel. Filed unassigned for triage; #5881 is out of scope for this and remains open on its own.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    domain:uiobjectui ui stream: fix lands on the published library or apps — objectui execution seatfinding

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions