test(plugin-detail): stop the record:highlights header narrating a parse mode - #6926
Merged
Merged
Conversation
…rse mode
`recordHighlightsInputs.spec-parity.test.ts` took the pin-aware disposition in
its body but not in its module header. The header still read:
`RecordHighlightsProps` is a plain `z.object`, so an unknown top-level key
is STRIPPED on parse with no error
Measured on this merge-base against the installed `@objectstack/spec` 17.2.0,
with a declared-key control in the same run:
control(declared keys only).success = true
probe(+undeclared top-level key).success = false
MODE = strict; issue codes = ["unrecognized_keys"]
unrecognized_keys names = ["__objectui_5881_probe__"]
So "STRIPPED on parse with no error" is false as written, and forty lines below
the same file already computes the fact behaviourally as
`specRefusesUnknownTopLevelKeys`.
The verdict the paragraph exists for is unchanged and pin-independent: a
top-level input the spec does not declare is actively misleading. Only the
mechanism it cited was falsified, so the header now states the verdict, notes
that the contract expresses it two ways depending on the installed pin, and
points at the file's own probe instead of asserting either mode as a
present-tense fact -- narrating the other mode as fact would be the same defect
with the sign flipped.
Comment-only. `git diff` on the file carries zero non-comment +/- lines; test
file and test counts are identical before and after (1 file, 5 tests). The
changeset declares empty frontmatter: nothing releases.
Co-authored-by: Claude <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013hfmP9hoMd3dJwTh85J4yB
Contributor
✅ Console Performance Budget
The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it. 📦 Bundle Size Report
Size Limits
|
os-sam
marked this pull request as ready for review
August 31, 2026 01:17
This was referenced Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5881
packages/plugin-detail/src/__tests__/recordHighlightsInputs.spec-parity.test.tstook the pin-aware disposition in its body but not in its module header. Forty lines above the file's own behavioural probe, the header still narrated a parse mode as a present-tense fact about the installed@objectstack/spec:Re-measured on this branch's merge-base — not copied from the card
The card's numbers were taken on
1939c9610. This branch's merge-base ise3d117ae1, installed@objectstack/spec17.2.0. Measured with a declared-key control in the same run, so a red probe cannot be a rejection offields:Control green, probe red, exactly one
unrecognized_keysnaming exactly the probe key. The premise holds: "STRIPPED on parse with no error" is false as written on this pin.What changed
The paragraph's verdict was never falsified — publishing a top-level input the spec does not declare is actively misleading — only the mechanism it cited. So the verdict stays and the mechanism is replaced by a pin-independent statement that names both shapes as alternatives and hands the present-tense question to the file's own
specRefusesUnknownTopLevelKeys. Narrating strict mode as fact would be the same defect with the sign flipped, so the new text asserts neither.Comment-only, proven rather than claimed
No assertion added, changed or removed — that is deliberately #5887's separate work, not this branch's.
Verification (exit codes captured before any pipe; verdict lines quoted from the tools themselves)
Run at
47c3da232, the branch head this PR carries.pnpm exec vitest run packages/plugin-detail/src/__tests__/recordHighlightsInputs.spec-parity.test.ts(repo root) beforeTest Files 1 passed (1)/Tests 5 passed (5)—VERDICT command-exit 0Test Files 1 passed (1)/Tests 5 passed (5)—VERDICT command-exit 0— identical, since nothing executable changedpnpm --filter @object-ui/plugin-detail type-check> @object-ui/plugin-detail@17.6.0 type-check/> tsc --noEmit && tsc -p tsconfig.test.json—VERDICT command-exit 0pnpm exec eslint .inpackages/plugin-detail(plain form)✖ 880 problems (0 errors, 880 warnings), exit 0 — all pre-existing; targeted--format jsonon the edited file reportserrors= 0 warnings= 0node scripts/check-changeset-presence.mjs✅ 1 source file(s) of 1 released package(s) changed, and this change declares 1 changeset(s)…Every one of them has an EMPTY frontmatter — declared as releasing nothingnode scripts/check-changeset-no-major.mjs✅ No changeset declares a 'major' bump.The first
type-checkread RED withCannot find module '@object-ui/react'and friends — the unbuilt-closure false RED.pnpm --workspace-concurrency=2 --filter '@object-ui/plugin-detail^...' buildthen re-run gives the green above. The script name is echoed in both readings, so neither is a zero-match silent pass.tsc -p tsconfig.test.json --listFileslists the edited file (1 hit), so the green is a measurement of it and not a coverage gap.Scope
Exactly one source file plus its "releases nothing" changeset.
recordDetailsInputs.spec-parity.test.tsandrecordRelatedListInputs.spec-parity.test.tsare untouched — they belong to #5887, which is in flight in parallel.Out of scope, filed rather than fixed: #6925 — 11 files still call
17.0.0-rc.6"the pinned"@objectstack/specwhile no manifest in the workspace declares that range and the installed version is 17.2.0. Two of those files are #5887's, so it wants sequencing, not a drive-by here.⛔ Draft on purpose. The PM lands it: do not mark ready, do not enqueue, do not enable auto-merge.
Generated by Claude Code