fix: show all sidebar pin icons only on hover - #1056
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update sidebar pin icons to show on hover
fix: show all sidebar pin icons only on hover
Mar 9, 2026
hotlong
marked this pull request as ready for review
March 9, 2026 08:28
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a cluttered sidebar UX where all currently-pinned navigation items permanently displayed a "PinOff" (unpin) icon. By changing showOnHover={!item.pinned} to showOnHover (always true) on both SidebarMenuAction instances, all pin/unpin icons now only appear on hover. Users still identify their pinned items via the Favorites section.
Changes:
- Pin/unpin icons in the sidebar are now hover-only for all items (pinned or not), eliminating visual clutter when many items are pinned.
- ROADMAP.md updated to reflect the new, corrected behavior description.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/layout/src/NavigationRenderer.tsx |
Removes the conditional !item.pinned from showOnHover on both the action-type and leaf-type SidebarMenuAction instances, making all pin/unpin icons hover-only. |
ROADMAP.md |
Updates the P2.9 changelog entry to accurately describe the new always-hover behavior instead of the previous conditional description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pinned navigation items permanently display the PinOff icon, cluttering the sidebar when many items are pinned.
showOnHover={!item.pinned}→showOnHoveron bothSidebarMenuActioninstances inNavigationRenderer.tsx(action-type and leaf items)Previously,
!item.pinnedevaluated tofalsefor pinned items, keeping the unpin icon always visible. Now all pin/unpin icons are hover-only. Users still identify pinned items via the Favorites section.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.