Skip to content

fix: show all sidebar pin icons only on hover #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hotlong merged 2 commits into from
Mar 9, 2026
Merged

fix: show all sidebar pin icons only on hover #1056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0050a74
Initial plan
Copilot Mar 9, 2026
a76ce1f
fix: make all pin/unpin icons show only on hover for cleaner sidebar
Copilot Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ROADMAP.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1112,7 +1112,7 @@ The `FlowDesigner` is a canvas-based flow editor that bridges the gap between th
> Platform-level sidebar, navigation, and grid/table UX improvements (Issue #XX).

**Sidebar Navigation:**
- [x] Pin icons show-on-hover: `SidebarMenuAction` in `NavigationRenderer` now uses `showOnHover={!item.pinned}` — unpinned items show pin icon only on hover; pinned items always show unpin icon. Applied to both `action` and leaf navigation item types.
- [x] Pin icons show-on-hover: `SidebarMenuAction` in `NavigationRenderer` now uses `showOnHover` (always true) — all pin/unpin icons only appear on hover for a cleaner sidebar. Applied to both `action` and leaf navigation item types.
- [x] Search placeholder contrast: Search icon in AppSidebar improved from `opacity-50` → `opacity-70` for better readability.
- [x] Recent section position: Recent items section moved above Record Favorites in AppSidebar for quicker access to recently visited items.
- [x] Favorites section: Already hides automatically when no pinned items exist (verified).
Expand Down
4 changes: 2 additions & 2 deletions packages/layout/src/NavigationRenderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,7 @@ function NavigationItemRenderer({
</SidebarMenuButton>
{enablePinning && onPinToggle && (
<SidebarMenuAction
showOnHover={!item.pinned}
showOnHover
onClick={() => onPinToggle(item.id, !item.pinned)}
aria-label={item.pinned ? `Unpin ${resolveLabel(item.label, tProp)}` : `Pin ${resolveLabel(item.label, tProp)}`}
>
Expand Down Expand Up @@ -502,7 +502,7 @@ function NavigationItemRenderer({
</SidebarMenuButton>
{enablePinning && onPinToggle && (
<SidebarMenuAction
showOnHover={!item.pinned}
showOnHover
onClick={() => onPinToggle(item.id, !item.pinned)}
aria-label={item.pinned ? `Unpin ${itemLabel}` : `Pin ${itemLabel}`}
>
Expand Down