fix(fields): 记录选择器筛选面板的 select 筛选项改从引用对象 schema 取 options (#3336) by yinlianghui · Pull Request #3421 · objectstack-ai/objectui

yinlianghui · 2026-08-06T02:30:57Z

问题

lookup「浏览全部记录」记录选择器的筛选面板里,由 typed picker column 派生出来的 select 筛选项不带 options,筛选面板的 renderFilterInput 渲染的是 col.options?.map(...),于是 SelectContent 为空 —— 下拉展开什么都没有,这一列根本无法筛选。

同一列的表格单元格自 #3333 起已经能解析选项 label(走 fieldsMeta + 共享 i18n option 翻译),所以这是同一个控件的另一面:单元格对了,筛选输入框还是空的。

定位复核(issue body 只是线索,逐条对 origin/main 核过)

packages/fields/src/widgets/LookupField.tsx:376-386 filterColumns useMemo 仍然只 push { field, label, type },不带 options —— 成立;
packages/fields/src/widgets/RecordPickerDialog.tsx renderFilterInput 的 select 分支仍是 col.options?.map(...) —— 成立;
[console] lookup「浏览全部记录」记录选择器:select 字段列不解析选项 label,显示首字母大写的裸 value(manufacturing → Manufacturing) #3333 的富化确实在:LookupField.tsx:1280 已经把 fieldsMeta={refObjectSchema?.fields} 传给了 dialog,dialog 里有 columnFieldDescriptors 走 translateOptions —— 可复用,成立。

改法

把选项解析抽成 resolveSchemaOptions(meta, objectName, fieldName, translateOptions),单元格描述符和筛选列共用同一个 resolver:

单元格路径([console] lookup「浏览全部记录」记录选择器:select 字段列不解析选项 label,显示首字母大写的裸 value(manufacturing → Manufacturing) #3333)行为不变,只是改为调用同一个函数;
筛选列在 select 且自身没有 options 时,从 fieldsMeta[col.field].options 取,并过同一条 i18n option 翻译路径。

因此筛选下拉与表格单元格不可能对同一个选项给出不同的名字 —— 这是本 PR 的关键取舍:没有在 LookupField 里再写一份"筛选专用"的派生逻辑(那样两边会各自漂移),LookupField 本次零改动。

刻意保留的两条边界(都有测试钉住):

显式 options 优先:筛选列自带 options(包括 lookup_filters 的 in/notIn 自动派生出来的那一份)不会被 schema 的全量选项覆盖 —— 那会把作者刻意收窄的列表重新放宽;
不做消费端兜底:schema 里本来就没有 options 的 select 字段,下拉仍然是空的。不会拿当前这一页记录里出现过的裸值现编选项(那样列表会随翻页变化,还会把元数据缺口盖住)。

测试与反向验证(方向是先预判、后运行的)

新增 packages/fields/src/widgets/RecordPickerDialog.filterOptions.test.tsx(7 例)。把修改 stash 掉、只留测试跑了一遍,方向与预判完全一致:

预判 RED → 实测 RED(5 例):renderFilterBar 拿到的筛选列带 schema options、内置筛选面板下拉里出现两个 option、选中后 $filter 落到 project_phase: 'manufacturing'、i18n 平价用例、以及 LookupField → 筛选面板的端到端串联。失败信息分别是 expected undefined to deeply equal [ …(2) ] 和 Unable to find role="option" and name "03 Manufacturing"。
预判 GREEN(no-op pin)→ 实测 GREEN(2 例):schema 无 options 时保持空下拉、显式 options 优先。这两例修复前后都绿,它们钉的是本 PR 选择的"不兜底/优先级",不是被修复的缺陷 —— 报告里也是这么写的,没有当成 RED 邀功。

其中 i18n 平价用例是最吃重的一例:在 zh provider 下断言筛选项 label 与同字段单元格是同一个被翻译过的字符串。一份只读 meta.options、绕过 i18n 的"筛选专用"派生能通过前面几例,但过不了这一例。

命令与结果(均在 worktree 仓库根跑 vitest,已确认目标文件名出现在 verbose 输出里):

npx vitest run --maxWorkers=2 packages/fields --reporter=dot → Test Files 60 passed (60) / Tests 924 passed (924)
npx vitest run --maxWorkers=2 packages/plugin-detail packages/app-shell/.../AccessExplainPanel.test.tsx packages/app-shell/.../AssignedUsersSection.test.tsx → Test Files 52 passed (52) / Tests 453 passed (453)(按"规则消费半径"扫的下游:RelatedList / AccessExplainPanel / AssignedUsersSection 都是 RecordPickerDialog 的调用方)
pnpm --workspace-concurrency=2 --filter @object-ui/fields type-check → 通过(先 pnpm --filter '@object-ui/fields^...' build 建好依赖 dist,否则是假红)
node scripts/check-control-bytes.mjs → OK;eslint 改动文件 → 0 errors

已附 changeset(.changeset/record-picker-filter-select-options.md,patch)。未触碰 content/docs/releases/。

Generated by Claude Code

…tions (#3336) The lookup "Browse all records" picker derives a filter column from every typed picker column, but those carried no `options` — so the filter panel's `select` input rendered `col.options?.map(...)` over `undefined` and the dropdown opened EMPTY, leaving the column unfilterable. The same column's table CELLS had resolved their option labels since #3333. RecordPickerDialog now fills a `select` filter column's missing `options` from `fieldsMeta` (the referenced object's schema `fields` map) through `resolveSchemaOptions` — the same resolver, and the same i18n option translation, the cell descriptors use — so the filter dropdown and the cells cannot drift apart. Explicitly authored filter options still win (including the ones auto-derived from an `in`/`notIn` `lookup_filters` entry), and a schema field that declares no options keeps an empty dropdown: nothing is synthesised from the loaded page's raw stored values. LookupField is unchanged: it already passes `fieldsMeta`, and resolving the options in the dialog keeps ONE source for both faces of the widget instead of a second, filter-only derivation. Fixes #3336 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GTRjn8xBqp75dk7kFupVRt

vercel · 2026-08-06T02:31:02Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Aug 6, 2026 2:31am

github-actions · 2026-08-06T02:33:45Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	28.1 KB	350 KB
Entry file	`index-BbidFLlS.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	8.47KB	3.09KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	22.10KB	4.37KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	18.13KB	5.39KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.64KB	2.21KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	35.76KB	9.11KB
auth (createAuthenticatedFetch.js)	4.37KB	1.69KB
auth (index.js)	2.35KB	1.07KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.91KB	0.87KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	478.45KB	105.05KB
core (index.js)	2.47KB	0.91KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	136.23KB	34.75KB
fields (index.js)	229.34KB	56.32KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.65KB	1.06KB
i18n (pickLocalized.js)	1.70KB	0.83KB
i18n (provider.js)	9.48KB	3.27KB
i18n (useObjectLabel.js)	26.14KB	6.07KB
i18n (useSafeTranslation.js)	3.26KB	1.44KB
layout (index.js)	38.53KB	10.71KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	4.05KB	1.53KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	8.75KB	3.06KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.67KB	1.12KB
permissions (evaluator.js)	4.41KB	1.44KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.55KB	0.71KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	44.98KB	12.37KB
plugin-charts (index.js)	61.04KB	17.31KB
plugin-chatbot (index.js)	180.09KB	42.72KB
plugin-dashboard (index.js)	112.03KB	28.88KB
plugin-designer (index.js)	210.51KB	42.51KB
plugin-detail (index.js)	232.48KB	57.34KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	111.54KB	26.97KB
plugin-gantt (index.js)	162.55KB	39.57KB
plugin-grid (index.js)	185.08KB	49.04KB
plugin-kanban (index.js)	47.89KB	13.18KB
plugin-list (index.js)	105.02KB	25.36KB
plugin-map (index.js)	16.81KB	5.24KB
plugin-markdown (index.js)	13.72KB	4.69KB
plugin-report (index.js)	40.58KB	10.58KB
plugin-timeline (index.js)	25.76KB	7.33KB
plugin-tree (index.js)	8.34KB	2.82KB
plugin-view (index.js)	83.67KB	20.43KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.67KB	2.37KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	19.28KB	6.38KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.02KB	0.55KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	4.47KB	2.03KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.87KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (http-retry.js)	4.32KB	2.02KB
types (index.js)	2.46KB	1.21KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.05KB	1.93KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	3.40KB	1.71KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

github-actions Bot added the tests label Aug 6, 2026

yinlianghui mentioned this pull request Aug 6, 2026

[fields] 记录选择器筛选面板:select 筛选项一律按字符串下发,lookup_filters 派生的数字/布尔选项筛不出记录 #3422

Closed

yinlianghui marked this pull request as ready for review August 6, 2026 02:39

yinlianghui added this pull request to the merge queue Aug 6, 2026

Merged via the queue into main with commit 5881a2c Aug 6, 2026
17 checks passed

yinlianghui deleted the claude/issue-3336-picker-filter-options branch August 6, 2026 02:40

Navigation Menu

Uh oh!

fix(fields): 记录选择器筛选面板的 select 筛选项改从引用对象 schema 取 options (#3336) - #3421

fix(fields): 记录选择器筛选面板的 select 筛选项改从引用对象 schema 取 options (#3336)#3421
yinlianghui merged 1 commit into
mainfrom
claude/issue-3336-picker-filter-options

yinlianghui commented Aug 6, 2026

Uh oh!

vercel Bot commented Aug 6, 2026

Uh oh!

github-actions Bot commented Aug 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

yinlianghui commented Aug 6, 2026

问题

定位复核(issue body 只是线索,逐条对 origin/main 核过)

改法

测试与反向验证(方向是先预判、后运行的)

Uh oh!

vercel Bot commented Aug 6, 2026

Uh oh!

github-actions Bot commented Aug 6, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants