Remove property chains inferring develops_from over part_of.#1808
Merged
Remove property chains inferring develops_from over part_of.#1808
Conversation
cmungall
approved these changes
Apr 12, 2021
Contributor
|
Just spotted this. I think the second of these two property chains is kosher and should be in RO. |
Member
Author
|
@dosumis I think that chain leads to weird statements: 'neuron projection bundle' develops_from 'multicellular organism' |
This was referenced Apr 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes two property chains:
part_of o develops_from -> develops_fromdevelops_from o part_of -> develops_fromWe noticed these causing some unexpected inferences in GO, for example
protein-containing complexbeing inferred to develop from ananatomical entity. These should be in RO anyway, if they were to be accepted.I also deleted these chains from the
cl_import.owl. I looked at the CL source, and I think they got these via Uberon, so hopefully that bit of ontology autophagy will be cleaned up when both have releases.I computed a reasoned file using this command:
robot reason --catalog catalog-v001.xml --exclude-duplicate-axioms true --remove-redundant-subclass-axioms true -i uberon_edit.obo -o reasoned-new.ofnand compared before and after the changes using
robot diff. Somewhat unexpectedly, I didn't see any classification differences.