Premultiplied alpha blend state instead of math - #318
Merged
Conversation
Contributor
Author
|
In draft mode until required PR is merged. |
jpark37
force-pushed
the
srgb-decompress
branch
from
September 30, 2021 17:19
8442d29 to
95e1e24
Compare
Code is about to stale, so just remove for now.
jpark37
force-pushed
the
srgb-decompress
branch
from
September 30, 2021 20:27
95e1e24 to
3d46c65
Compare
This is an attempt to preserve RGB channels to behave like Chrome. This should work on a black background, but blending against anything else will be done in linear space, and may not match previous OBS behavior.
Adapt existing fix for Windows game capture.
jpark37
force-pushed
the
srgb-decompress
branch
from
October 1, 2021 04:30
3d46c65 to
450ae20
Compare
jpark37
marked this pull request as ready for review
October 1, 2021 05:44
Contributor
Author
|
Seems to work as I expect on Windows, Ubuntu, and macOS (with and without browserhwaccel). |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is an attempt to preserve RGB channels to behave like Chrome. This
should work on a black background, but blending against anything else
will be done in linear space, and may not look as expected.
Requires obsproject/obs-studio#5354
Motivation and Context
People want semi-transparency to work as expected.
How Has This Been Tested?
WebM video supplied by #5347 seems to look like Chrome in browser source with or without default custom CSS.
Types of changes
Checklist: