-
Notifications
You must be signed in to change notification settings - Fork 4
Release/0.1.17 #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Release/0.1.17 #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ia-method Refactor: Pull Datafile metadata gathering into method
This avoids needless deserialisation.
Posix timestamps are converted to datetime timestamps on Datafile instantiation
This avoids strings in the metadata appearing in two sets of quotation marks on Google Cloud Storage.
…-not-appear-in-quotation-marks Ensure Google Cloud Storage metadata strings do not appear in quotation marks
…s-and-slashes-in Feature: Allow tags to have capitals and forward slashes in
…or/group-datafile-metadata-via-method
…ata-via-method Allow datetime timestamps for datafiles; use GCS custom time field for Datafile.timestamp
…or/remove-hash-value-from-gcs-metadata
…or/consolidate-cloud-datafile-usage
…om-gcs-metadata Remove hash value from Datafile GCS metadata
…le-change Fix: Revert custom time datafile metadata change
…or/consolidate-cloud-datafile-usage
skip_ci_tests
…tafile-usage Consolidate cloud datafile usage
Codecov Report
@@ Coverage Diff @@
## main #158 +/- ##
==========================================
+ Coverage 94.61% 95.00% +0.39%
==========================================
Files 54 55 +1
Lines 1540 1622 +82
==========================================
+ Hits 1457 1541 +84
+ Misses 83 81 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contents
New Features
Datafileto be used as a context manager for changes to local datafilesDatafile.from_cloudto be used as a context manager for changes to cloud datafilesDatafileto remember where in the cloud it came fromDatafile:get_cloud_metadataupdate_cloud_metadataclear_from_file_cache_get_cloud_location_store_cloud_location_check_for_attribute_conflictDatafilefile or metadata if they haven't changedDatafileGoogleCloudStorageClient.update_metadatamethodDatafilecloud methodsdatetimeand posix timestamps forDatafile.timestampDatafile.posix_timestamppropertyBreaking changes
hash_valuefromDatafileGCS metadataDatafiles, only hash represented file (i.e. stop hashing metadata)Datasets andManifests, only hash the files contained (i.e. stop hashing metadata)Hashableinstance with_ATTRIBUTES_TO_HASH=Nonethe empty string hash value"AAAAAA=="Minor improvements
GoogleCloudStorageClient.get_metadataHashableinstances re-calculate theirhash_valueevery time unless animmutable_hash_valueis explicitly provided (e.g. for cloud datafiles where you don't have the file locally to hash)Identifiable._set_idmethodDatafileinto methoddatetimeobjects directly from GCS blob instead of parsing string serialisationstimeutils moduleHashablefordatetimeinstancesDatafileif GCScrc32cmetadata isn't presentManifest,Dataset, andDatafileFixes
kwargswhen usingDatafile.from_cloudTesting
Quality Checklist