[IMP] Sales: Optional product page rewrite #15588
Conversation
|
|
|
jk, @erjer-odoo can you actually review this ahead of @Felicious? I've heard that we're starting the round-robin peer review process at this time. Thank you! |
erjer-odoo
left a comment
erjer-odoo
left a comment
There was a problem hiding this comment.
Hi @theRealThagomizer ! This looks great! I did notice one typo, but this is otherwise good to go, I think! Approving, and after you fix the typo and checks pass, you should be able to pass this along to merge.
| Additional products can also be added to a core product by clicking :guilabel:`Search more...`. This | ||
| opens the :guilabel:`Search: Optional Products` form, which displays all products in the catalog and | ||
| includes the :guilabel:`New` button to create a new product. Multiple products may be selected as | ||
| optional prodcuts at once when using this form by clicking their checkboxes and then clicking |
There was a problem hiding this comment.
| optional prodcuts at once when using this form by clicking their checkboxes and then clicking | |
| optional products at once when using this form by clicking their checkboxes and then clicking |
theRealThagomizer
force-pushed
the
19.0-sales-optional-products-update-thjud
branch
from
9398189 to
814c96e
Compare
|
Thanks, @erjer-odoo! @Felicious, this is ready for your review to see if it's ready to be merged. Thanks! |
Felicious
left a comment
Felicious
left a comment
There was a problem hiding this comment.
Gj @theRealThagomizer !
Your updates address the feature change and I like that you've reduced the writing so that it's clearer and concise! I had a comment to address the quotation template workflow that used to work in 18.0 is clarified to not work anymore in 19.0, as well as a potential essentials content trim that could potentially make this doc even shorter and sweeter! Though that seems to be a little bit out of scope for this change 🤔
My other comments are optional, so good work getting more familiar with the team's style (:
Although I'm delegating, I noticed an issue that seems to be within Niki's technical scope. In my local build, I'm not able to get the "On this page" column on the side of this page to show up! Could you ask @nikibrown to look into this?
expected ):
@robodoo delegate+
content/applications/sales/sales/sales_quotations/optional_products.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/sales_quotations/optional_products.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/sales_quotations/optional_products.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/sales_quotations/optional_products.rst
Outdated
Show resolved
Hide resolved
| To delete an optional product from the product form, simply click the :icon:`fa-times` | ||
| :guilabel:`(Delete)` icon. | ||
|
|
||
| .. image:: optional_products/optional-products-product-form.png | ||
| :alt: The optional products section of product forms in Odoo Sales | ||
|
|
||
| Additional products can also be added to a core product by clicking :guilabel:`Search more...`. This | ||
| opens the :guilabel:`Search: Optional Products` form, which displays all products in the catalog and | ||
| includes the :guilabel:`New` button to create a new product. Multiple products may be selected as | ||
| optional products at once when using this form by clicking their checkboxes and then clicking | ||
| :guilabel:`Select`. | ||
|
|
||
| .. image:: optional_products/search-optional-products-form.png | ||
| :alt: The Search: Optional Products form accessed by clicking Search more... |
There was a problem hiding this comment.
deleting a product and searching products seem a little like essentials content to me, where it's not too hard to do, or is the same across most apps and workflows. However, the "Search more.." feature isn't documented anywhere, to my knowledge.
Can we revisit this in a follow-up PR, where we try to place where this content would live and then come back to this section to reduce?
However! If you tell me that you have supporting data from a BSA or youtube comment or something that implies that customers struggle to delete and search for additional products, we can leave this as is :D
|
Hi @nikibrown! Just tagging you to get help looking into the sidebar not showing up (: There's no need for you to do a full-fledged tech review. Thanks! :D |
@Felicious, after poking around some other documentation pages and viewing them in GitHub, I believe there's no "On this page" sidebar because there's only a single section. It seems like a page needs to have a minimum of two sections/subsections before the sidebar appears.
|
|
@theRealThagomizer beat me to it! Great detective work! 🕵️ The code that builds the TOC section checks for less than 2 headings in addition to the title and hides things accordingly. https://github.com/odoo/documentation/blob/19.0/extensions/odoo_theme/static/js/page_toc.js#L10 
|
theRealThagomizer
force-pushed
the
19.0-sales-optional-products-update-thjud
branch
from
814c96e to
8ea2c22
Compare
|
@nikibrown Got @Felicious's updates implemented. If you want to take a peek, this is ready for you. Otherwise, I'll tag in robodoo and we can check this off! |
Co-authored-by: Erin Jerison <erjer@odoo.com> Co-authored-by: Felicia Kuan <feku@odoo.com> Co-authored-by: Niki Brown <nikbr@odoo.com
theRealThagomizer
force-pushed
the
19.0-sales-optional-products-update-thjud
branch
from
8ea2c22 to
2eb01b8
Compare
nikibrown
left a comment
nikibrown
left a comment
There was a problem hiding this comment.
@theRealThagomizer make review issues resolved. LGTM 🚀 cc @StraubCreative with merging powers.
|
@robodoo delegate+ |
|
@robodoo r+ |
6 participants
Hello, Felicia! This PR was created to resolve this task: https://www.odoo.com/odoo/action-4043/5226235. The original lift was simply to update the document from 18.0 -> 19.0, but after review, I decided the functionality had changed enough that the document needed to be wholly rewritten. I also replaced all of the photos with the modern UI and some screenshots of the quotations and eCommerce experiences so that readers can see what Optional Products actually look like on the customer's end.
This 19.0 PR can be FWP up to master.