[ADD] Sales: New accessory products page #15600
Conversation
|
|
|
The newline error has been corrected. Darn newline error. |
theRealThagomizer
force-pushed
the
19.0-sales-accessory-products-thjud
branch
from
7a4110d to
8de134f
Compare
|
@jero-odoo I pre-emptively went in and pushed a new version of this page that addresses the newline issue and implements the relevant style choices we discussed in our meeting today. Hopefully that'll make your review easier. Thanks! |
jero-odoo
left a comment
jero-odoo
left a comment
There was a problem hiding this comment.
Hey @theRealThagomizer, Nice work on this new doc! I have some feedback (see comments), and some additional thoughts. I think the doc would benefit from one or more use cases regarding when to select an accessory product. I know you had the line in the intro about the sleeping bag, which is a great option, but I think it would be more interesting to see a more well-rounded use case/example. Specifically, if you can think of one that gives a better idea of why you would choose optional products (which to me is usually something like a warranty) vs accessory products, it will help differentiate between those.
Let me know if you have any questions or want to talk this out. Thanks!
content/applications/sales/sales/products_prices/accessory_products.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/accessory_products.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/accessory_products.rst
Outdated
Show resolved
Hide resolved
| Accessory products | ||
| ================== | ||
|
|
||
| The use of accessory products is a marketing strategy that involves the cross-selling of useful and |
There was a problem hiding this comment.
I think this intro needs rewriting to highlight not just the business use for these products, but how they fit into the Odoo ecosystem. Something like, "In Odoo, accessory products are added to a product record so that blah blah"
| .. figure:: accessory_products/accessory-products-ecommerce.png | ||
| :alt: A screenshot of an eCommerce shopping cart showing accessory products. | ||
|
|
||
| Accessory products as they appear in an eCommerce website shopping cart. |
There was a problem hiding this comment.
Nice use of the figure markup! I do think this image could be smaller, maybe only show one or two accessory products? Coming right after a very large admonition block it is a bit overwhelming
There was a problem hiding this comment.
Hm. I'll noodle on this one. I took the screenshot to align with the products listed in the product form further down the page. I was going for continuity between the screenshots, but I see what you mean about the size of the two blocks back to back.
content/applications/sales/sales/products_prices/accessory_products.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/products_prices/accessory_products.rst
Outdated
Show resolved
Hide resolved
theRealThagomizer
force-pushed
the
19.0-sales-accessory-products-thjud
branch
from
2765a64 to
ba01f9d
Compare
|
Hiya, @jero-odoo! You'll notice that this PR has some edits beyond what you'd suggested. Felicia had some notes on a related PR that she was reviewing, and I took the liberty of applying them here since the two were so structurally and thematically similar. |
Co-authored-by: Jess Rogers <jero@odoo.com>
theRealThagomizer
force-pushed
the
19.0-sales-accessory-products-thjud
branch
from
ba01f9d to
ac23350
Compare
3 participants
Hiya, @jero-odoo! Got a new page that explains what accessory products are and how to configure them in the Sales app. This new page was inspired by updating/rewriting the existing optional products page for this PR, so there's a good amount of overlap between this PR and that one.
Thanks for your review!