landed costs not limited to automated valuation #1818
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 547d90a allowed `BUILD_DIR` to be defined from the CLI but didn't update usages of `HTML_BUILD_DIR`. When building the documentation for multiple versions and/or languages, we should rely on `HTML_BUILD_DIR` to point to the appropriate directory. closes #1077 X-original-commit: 9bad054 Signed-off-by: Antoine Vandevenne (anv) <AntoineVDV@users.noreply.github.com>
The previous makefile was compiling css beside the style.scss and the style.css was copied at the end. The new makefile compile css directly in the build dir. Since this file was still present in the source because of the .gitignore, sphinx was using this old version of style.css, overriding the new compiled css file at the end. Removing it from gitignore should helpFix this problem. This commit also fix some path in makefile. (not critical but this should fix a potential error in static command) closes #1087 X-original-commit: fd56d8c Signed-off-by: Antoine Vandevenne (anv) <AntoineVDV@users.noreply.github.com> Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
When locally building the doc (aka make), CURRENT_LANG is not defined, which results in HTML_BUILD_DIR = _build/html//, resulting in commands & logs like the following mkdir -p _build/html//_static pysassc extensions/odoo_theme/static/style.scss _build/html//_static/style.css This has no impact on linux builds, but could be unclear/confusing for some non tech users (can it have any impact on other OS's/distros ?) closes #1095 X-original-commit: d8684e8 Signed-off-by: Antoine Vandevenne (anv) <AntoineVDV@users.noreply.github.com> Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
The list of Mexican accounting modules in the documentation was out of date, with many of them no longer existing. Several new modules have been added as well. closes #1113 Signed-off-by: Antoine Vandevenne (anv) <AntoineVDV@users.noreply.github.com>
The test server url for Carvajal T&S was out of date and has been updated with the correct one. Carvajal has also split into 2 different companies, with new customers using the new company (CSC) by default but the older company (CTS) still being available for existing customers. See task 2508208. So the documentation was updated to include both of them. CTS (Carvajal T&S) was being used to refer to Carvajal in general, so to avoid confusion those mentions have been changed to just "Carvajal" since it can refer to either CTS or CSC. closes #1125 Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
closes #1197 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
The english version has a confusing wording, using "strict ngligence" instead of "strict liability" in this sentence: "(...) regardless of the form of action, whether in contract, tort (including strict negligence) or any other legal (...)" In FR/BE this would seeem to refer to the notion of "responsabilité objective" ou "responsabilité sans faute". Yet this extra precision seems confusing and does not seem to add to the already broad clause. It seems simpler to omit it. The typical english wording for this clause is simply: "regardless of the form of action, whether in contract, tort or otherwise".
URL was pointing to a dead end. Update from http://werkzeug.pocoo.org/docs/contrib/fixers/#werkzeug.contrib.fixers.ProxyFix to https://werkzeug.palletsprojects.com/en/0.16.x/middleware/proxy_fix/#module-werkzeug.middleware.proxy_fix new URL as we are using 0.16.1 closes #1705 X-original-commit: 7ce175f Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
Codeowner regexes need images to be in the correct location, otherwise some image files might not be assigned to a GitHub team when the regex covering the parent folder is split into multiple codeowner rules. closes #1773 X-original-commit: 4e0a9b6 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
User tripped up due to the creation of a second warehouse enabling Storage Locations and changingthe workflow. https://www.odoo.com/forum/help-1/inventory-receipt-in-second-warehouse-199962 closes #1778 X-original-commit: bdf526a Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
as this was really restrictive, in V15, we dropped the condition to be in automated fifo or avco to create landed costs
Collaborator
Collaborator
|
@thomasdeleval Hello, it seems like you based your PR on the wrong base branch. You should probably cherry-pick your commit on top of a clean 15.0 base, or re-do your change if it's small enough. Also, I removed my review request since the codeowner team has been assigned. |
|
@thomasdeleval I am reviewing this now but cannot proceed. Can you rebase your branch on a clean 15.0 and push it back into the PR so I can focus on your changes solely? And also the naming convention for clarity on the changes such as: |
Collaborator
|
Continued in #1854. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as this was really restrictive, in V15, we dropped the condition to be in automated fifo or avco to create landed costs