[IMP] web: add ID to search input in CommandPalette - #110381
Closed
thjo-odoo wants to merge 0 commit into
Closed
Conversation
Contributor
|
|
thjo-odoo
marked this pull request as ready for review
January 19, 2023 10:22
C3POdoo
requested review from
a team,
FrancoisGe and
Polymorphe57
and removed request for
a team
January 19, 2023 10:23
thjo-odoo
force-pushed
the
master-knowledge-manage_visibility-thjo
branch
from
January 19, 2023 10:26
bd78302 to
5746db3
Compare
thjo-odoo
force-pushed
the
master-knowledge-manage_visibility-thjo
branch
2 times, most recently
from
February 10, 2023 10:42
ad73ab3 to
8b77e71
Compare
awa-odoo
reviewed
Feb 10, 2023
| <div class="o_command_palette_search input-group mb-2 px-4 py-3 border-bottom"> | ||
| <span t-if="state.namespace !== 'default'" class="o_namespace d-flex align-items-center me-1" t-out="state.namespace"/> | ||
| <input class="form-control border-0 p-0" type="text" data-allow-hotkeys="true" t-att-value="state.searchValue" t-ref="autofocus" t-att-placeholder="state.placeholder" t-on-input="onSearchInput" t-on-keydown="onKeyDown"/> | ||
| <input id="command_palette_input" class="form-control border-0 p-0" type="text" data-allow-hotkeys="true" t-att-value="state.searchValue" t-ref="autofocus" t-att-placeholder="state.placeholder" t-on-input="onSearchInput" t-on-keydown="onKeyDown"/> |
Contributor
There was a problem hiding this comment.
I'm not sure this is necessary, your xpath in knowledge could be something like:
<xpath expr="//div[hasclass('o_command_palette_search')]/input" position="after">
thjo-odoo
force-pushed
the
master-knowledge-manage_visibility-thjo
branch
4 times, most recently
from
February 15, 2023 07:05
2b797f5 to
072da1c
Compare
thjo-odoo
force-pushed
the
master-knowledge-manage_visibility-thjo
branch
from
February 15, 2023 12:35
072da1c to
f03dd28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds an ID to the input inside the CommandPalette template. It is needed because we are adding inside Knowledge via this PR, odoo/enterprise#34018, an icon near the input of the CommandPalette.
This is done in order to keep this inheritance in time and ensure that it will likely never be removed.
task-2900465
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr