Skip to content

[FIX] html_editor: button command in powerbox should create a button - #189893

Closed
Jinjiu96 wants to merge 1 commit into
odoo:18.0from
odoo-dev:18.0-fix-html-editor-button-creation-jili
Closed

[FIX] html_editor: button command in powerbox should create a button#189893
Jinjiu96 wants to merge 1 commit into
odoo:18.0from
odoo-dev:18.0-fix-html-editor-button-creation-jili

Conversation

@Jinjiu96

@Jinjiu96 Jinjiu96 commented Dec 6, 2024

Copy link
Copy Markdown
Contributor

Before this commit: Using the button command in the powerbox resulted in the creation of a regular link instead of a button.

After this commit: Executing the button command now correctly creates a primary button as intended.

task-4380129


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo

robodoo commented Dec 6, 2024

Copy link
Copy Markdown
Contributor

Pull request status dashboard

@C3POdoo
C3POdoo requested a review from a team December 6, 2024 13:55
@C3POdoo C3POdoo added the RD research & development, internal work label Dec 6, 2024
@Jinjiu96
Jinjiu96 force-pushed the 18.0-fix-html-editor-button-creation-jili branch 2 times, most recently from 684a893 to 255a509 Compare December 11, 2024 13:42
Comment thread addons/html_editor/static/src/main/link/link_plugin.js Outdated
@Jinjiu96
Jinjiu96 force-pushed the 18.0-fix-html-editor-button-creation-jili branch 2 times, most recently from f199261 to 0501488 Compare January 15, 2025 13:40
@dmo-odoo

Copy link
Copy Markdown
Contributor

@Jinjiu96 This PR is in conflict.

Before this commit: Using the button command in the powerbox resulted in
the creation of a regular link instead of a button.

After this commit: Executing the button command now correctly creates a
primary button as intended.

task-4380129
@Jinjiu96
Jinjiu96 force-pushed the 18.0-fix-html-editor-button-creation-jili branch from 0501488 to 40cbc3c Compare January 22, 2025 09:47
@dmo-odoo

Copy link
Copy Markdown
Contributor

@robodoo r+

@robodoo robodoo closed this in 6716147 Jan 24, 2025
adhoc-cicd-bot pushed a commit to adhoc-cicd/odoo-odoo that referenced this pull request Jan 26, 2025
Before this commit: Using the button command in the powerbox resulted in
the creation of a regular link instead of a button.

After this commit: Executing the button command now correctly creates a
primary button as intended.

task-4380129

closes odoo#189893

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
gamarino pushed a commit to numaes/numa-public-odoo that referenced this pull request Jan 27, 2025
Before this commit: Using the button command in the powerbox resulted in
the creation of a regular link instead of a button.

After this commit: Executing the button command now correctly creates a
primary button as intended.

task-4380129

closes odoo/odoo#189893

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
adhoc-cicd-bot pushed a commit to adhoc-cicd/odoo-odoo that referenced this pull request Jan 29, 2025
Before this commit: Using the button command in the powerbox resulted in
the creation of a regular link instead of a button.

After this commit: Executing the button command now correctly creates a
primary button as intended.

task-4380129

closes odoo#189893

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
adhoc-cicd-bot pushed a commit to adhoc-cicd/odoo-odoo that referenced this pull request Jan 29, 2025
Before this commit: Using the button command in the powerbox resulted in
the creation of a regular link instead of a button.

After this commit: Executing the button command now correctly creates a
primary button as intended.

task-4380129

closes odoo#189893

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
StephaneMangin pushed a commit to camptocamp/odoo that referenced this pull request Feb 6, 2025
Before this commit: Using the button command in the powerbox resulted in
the creation of a regular link instead of a button.

After this commit: Executing the button command now correctly creates a
primary button as intended.

task-4380129

closes odoo#189893

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
@fw-bot
fw-bot deleted the 18.0-fix-html-editor-button-creation-jili branch February 7, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RD research & development, internal work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants