Skip to content

Conversation

@fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Jun 27, 2025

Before this commit, the computation of the exclusion of some attributes based on other selected was going through every attribute to determine if it was excluded or not. This is now done once at the loading of the pos.


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #214243
Forward-Port-Of: #213789

@robodoo robodoo added forwardport This PR was created by @fw-bot conflict There was an error while creating this forward-port PR labels Jun 27, 2025
@robodoo
Copy link
Contributor

robodoo commented Jun 27, 2025

Pull request status dashboard

@fw-bot
Copy link
Contributor Author

fw-bot commented Jun 27, 2025

@adgu-odoo @davidmonnom cherrypicking of pull request #213789 failed.

stdout:

Auto-merging addons/point_of_sale/static/src/app/components/popups/product_configurator_popup/product_configurator_popup.js
Auto-merging addons/point_of_sale/static/src/app/services/pos_store.js
Auto-merging addons/point_of_sale/tests/test_frontend.py
CONFLICT (content): Merge conflict in addons/point_of_sale/tests/test_frontend.py

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

Before this commit, the computation of the exclusion of some attributes
based on other selected was going through every attribute to determine
if it was excluded or not. This is now done once at the loading of the
pos.

X-original-commit: 32b7aad
@adgu-odoo adgu-odoo force-pushed the saas-18.4-saas-18.2-perf-pos-product-attribute-exclude-for-adgu-442758-fw branch from a7c5be7 to a726a07 Compare July 1, 2025 08:36
@C3POdoo C3POdoo requested review from a team and stva-odoo and removed request for a team July 1, 2025 08:39
Copy link
Contributor

@adgu-odoo adgu-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

robodoo pushed a commit that referenced this pull request Jul 1, 2025
Before this commit, the computation of the exclusion of some attributes
based on other selected was going through every attribute to determine
if it was excluded or not. This is now done once at the loading of the
pos.

closes #216392

X-original-commit: 32b7aad
Signed-off-by: David Monnom (moda) <moda@odoo.com>
Signed-off-by: Adrien Guilliams (adgu) <adgu@odoo.com>
@robodoo robodoo closed this Jul 1, 2025
@fw-bot fw-bot deleted the saas-18.4-saas-18.2-perf-pos-product-attribute-exclude-for-adgu-442758-fw branch July 9, 2025 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants