Skip to content

[PERF] point_of_sale: excluding attributes values #217019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[PERF] point_of_sale: excluding attributes values #217019

wants to merge 1 commit into from

Conversation

@fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Jul 1, 2025

Before this commit, the computation of the exclusion of some attributes based on other selected was going through every attribute to determine if it was excluded or not. This is now done once at the loading of the pos.

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #216392
Forward-Port-Of: #213789

@robodoo
Copy link
Contributor

robodoo commented Jul 1, 2025

Pull request status dashboard

@fw-bot
Copy link
Contributor Author

fw-bot commented Jul 1, 2025

@adgu-odoo @davidmonnom cherrypicking of pull request #213789 failed.

stdout:

Auto-merging addons/point_of_sale/static/src/app/components/popups/product_configurator_popup/product_configurator_popup.js
Auto-merging addons/point_of_sale/static/src/app/services/pos_store.js
Auto-merging addons/point_of_sale/tests/test_frontend.py
CONFLICT (content): Merge conflict in addons/point_of_sale/tests/test_frontend.py

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added forwardport This PR was created by @fw-bot conflict There was an error while creating this forward-port PR labels Jul 1, 2025
@adgu-odoo adgu-odoo force-pushed the master-saas-18.2-perf-pos-product-attribute-exclude-for-adgu-446177-fw branch from 5a3eb3b to 6b7315b Compare July 7, 2025 07:49
@C3POdoo C3POdoo requested review from a team and stva-odoo and removed request for a team July 7, 2025 07:53
@fw-bot
Copy link
Contributor Author

fw-bot commented Jul 9, 2025

@adgu-odoo @davidmonnom this forward port of #213789 is awaiting action (not merged or closed).

3 similar comments
@fw-bot
Copy link
Contributor Author

fw-bot commented Jul 16, 2025

@adgu-odoo @davidmonnom this forward port of #213789 is awaiting action (not merged or closed).

@fw-bot
Copy link
Contributor Author

fw-bot commented Jul 23, 2025

@adgu-odoo @davidmonnom this forward port of #213789 is awaiting action (not merged or closed).

@fw-bot
Copy link
Contributor Author

fw-bot commented Jul 30, 2025

@adgu-odoo @davidmonnom this forward port of #213789 is awaiting action (not merged or closed).

@adgu-odoo adgu-odoo force-pushed the master-saas-18.2-perf-pos-product-attribute-exclude-for-adgu-446177-fw branch from 6b7315b to 3c0f3ab Compare August 13, 2025 09:42
@fw-bot
Copy link
Contributor Author

fw-bot commented Aug 27, 2025

@adgu-odoo @davidmonnom this forward port of #213789 is awaiting action (not merged or closed).

3 similar comments
@fw-bot
Copy link
Contributor Author

fw-bot commented Sep 24, 2025

@adgu-odoo @davidmonnom this forward port of #213789 is awaiting action (not merged or closed).

@fw-bot
Copy link
Contributor Author

fw-bot commented Oct 22, 2025

@adgu-odoo @davidmonnom this forward port of #213789 is awaiting action (not merged or closed).

@fw-bot
Copy link
Contributor Author

fw-bot commented Nov 19, 2025

@adgu-odoo @davidmonnom this forward port of #213789 is awaiting action (not merged or closed).

@adgu-odoo
[PERF] point_of_sale: excluding attributes values
ec42a0d 
Before this commit, the computation of the exclusion of some attributes
based on other selected was going through every attribute to determine
if it was excluded or not. This is now done once at the loading of the
pos.

X-original-commit: ea6323e
@adgu-odoo adgu-odoo force-pushed the master-saas-18.2-perf-pos-product-attribute-exclude-for-adgu-446177-fw branch from 3c0f3ab to ec42a0d Compare December 1, 2025 10:21
@adgu-odoo
Copy link
Contributor

adgu-odoo commented Dec 1, 2025

robodoo r+

robodoo pushed a commit that referenced this pull request Dec 1, 2025
@adgu-odoo
[PERF] point_of_sale: excluding attributes values
102eca3 
Before this commit, the computation of the exclusion of some attributes
based on other selected was going through every attribute to determine
if it was excluded or not. This is now done once at the loading of the
pos.

closes #217019

X-original-commit: ea6323e
Signed-off-by: David Monnom (moda) <moda@odoo.com>
Signed-off-by: Adrien Guilliams (adgu) <adgu@odoo.com>
@robodoo robodoo added the 19.1 label Dec 1, 2025
@robodoo robodoo closed this Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stva-odoo stva-odoo Awaiting requested review from stva-odoo stva-odoo was automatically assigned from odoo/pos

Assignees

No one assigned

Labels

19.1 conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fw-bot @robodoo @adgu-odoo