[FIX] mail: fix runbot error 231582 (no web_save when manually saving) by KevGerard · Pull Request #227484 · odoo/odoo

KevGerard · 2025-09-16T12:51:09Z

This commit tries to solve runbot issues with mail html fields widget.

It seems clicking on the save button manually is not generating a call
to the backend. This could be due to the fact the button is not enabled
due to the data being invalid. Therefore using the clickSave util could
be useful in those situation since waiting that the button becomes
enabled.

This solution is not 100% sure to fix the issue in all cases but
manually disabling the button is creating the issue we can observe in
those runbots. There is a good chance it might work.

fixes-runbot-231582
fixes-runbot-233049

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

robodoo · 2025-09-16T12:51:12Z

seb-odoo

I'm surprised there are many occurrences of click on o_form_button_save in tests and none of them have this pattern.

Are other tests failing too, and were never fixed?

And if not, what makes this test different?

seb-odoo · 2025-09-16T15:02:58Z

Also it might be easier for all of those PR to have the actual test name in the commit title (or something that helps in this regard), because having many runbot-{id} in my inbox doesn't really help seeing what each PR is about.

KevGerard · 2025-09-16T15:23:47Z

I'm surprised there are many occurrences of click on o_form_button_save in tests and none of them have this pattern.

Are other tests failing too, and were never fixed?

And if not, what makes this test different?

I will investigate a bit more, though my feeling is that the html editor is taking more time than other tests to notify of a change and therefore the save button could be not available right away.

KevGerard · 2025-09-16T16:24:16Z

I'm surprised there are many occurrences of click on o_form_button_save in tests and none of them have this pattern.
Are other tests failing too, and were never fixed?
And if not, what makes this test different?

I will investigate a bit more, though my feeling is that the html editor is taking more time than other tests to notify of a change and therefore the save button could be not available right away.

So indeed, after investigation the HtmlField is using an the internal bus to send notification that the icon has been chosen in this test, and is resetting the dirty flag of the form that shows the save button while choosing the icon.

It is definitely possible that hoot is returning before this bus notification and is therefore pushing on the save button being not ready.

This commit solves this issue because the dirty flag is a dependency to make the save button visible.

seb-odoo · 2025-09-16T16:42:31Z

Ok I found another one: https://runbot.odoo.com/odoo/error/161256

I think then all usages of o_form_button_save in tests should be covered by visibility check (and in all versions).

seb-odoo · 2025-09-16T16:44:52Z

@@ -147,6 +147,6 @@ test("HtmlMail add icon and save inline html", async function () {
    await contains("a.nav-link:contains('Icons')").click();
    await contains("span.fa-glass").click();

-    await contains(".o_form_button_save").click();
+    await contains(".o_form_button_save:not(.invisible)").click();


I think :visible is possible, there are some occurrences in code.

Might actually be better to use clickSave() from @web/../tests/web_test_helpers and stepUtils.saveForm() from @web_tour/tour_service/tour_utils for tours, that way we don't have to modify our tests every change.

I wasn't aware of these helpers, if it's their preferred way then yes I suppose this is what should be used. The :enabled state is properly linked to the :visible state?

Actually no, but we can add a modifier in the clickSave({ modifier: "visible" }) which might be useful and more readable anyway. For the tours, we'll have to do it manually though.

Do we really need a param? It looks like it should be the default, always checked?

seb-odoo · 2025-09-16T16:54:37Z

https://runbot.odoo.com/odoo/error/230493 looks related?

https://runbot.odoo.com/odoo/error/232486 why would it click when not visible instead???

seb-odoo · 2025-09-16T16:56:06Z

And potentially 105 other race conditions where this selector is potentially the problem:

This has many old ones, but at least 20 are from this year.

seb-odoo · 2025-09-16T17:03:22Z

According to the template, click on o_form_button_cancel should be similarly covered.
And also checking code making use of o_form_status_indicator_buttons for good measure.

KevGerard · 2025-09-17T10:15:49Z

https://runbot.odoo.com/odoo/error/232486 why would it click when not visible instead???

I guess to click on an invisible button to save something that was already saved 2 steps before...

KevGerard · 2025-09-17T11:12:08Z

https://runbot.odoo.com/odoo/error/230493 looks related?

It does not look related to this problem. Looks like a UI issue, the tab should be there in all cases (saved form or not).

seb-odoo · 2025-09-17T11:17:23Z

Right, I just saw it only happens in single ln10 country ch, so probably just a bad override in that module.
We can still add :visible in there to be safe, but then we don't mark the issue as closed by this PR.

KevGerard · 2025-09-23T08:05:29Z

So after some more investigation, I was wrong and this is actually not the problem. The contains function is actually already checking the button is visible, so this visible tag is actually useless.

On top of that, the issue here is that the web_save http call is not received when clicking manually on the save button.

I am looking further to try and find the real reason this issue could happen. It might just be that the added icon is not yet added to the record and therefore no changes is yet found, hence no save.

seb-odoo · 2025-09-29T08:31:05Z

Thank you for the follow up, let us know when you find a solution.

This commit tries to solve runbot issues with mail html fields widget. It seems clicking on the save button manually is not generating a call to the backend. This could be due to the fact the button is not enabled due to the data being invalid. Therefore using the clickSave util could be useful in those situation since waiting that the button becomes enabled. This solution is not 100% sure to fix the issue in all cases but manually disabling the button is creating the issue we can observe in those runbots. There is a good chance it might work. fixes-runbot-231582 fixes-runbot-233049

KevGerard · 2025-10-03T14:24:01Z

@seb-odoo As said in the description, the new update should be solving the 2 runbot issues even though not 100% sure. In any case it is better/safer than the previous solution.

seb-odoo

@robodoo r+

This commit tries to solve runbot issues with mail html fields widget. It seems clicking on the save button manually is not generating a call to the backend. This could be due to the fact the button is not enabled due to the data being invalid. Therefore using the clickSave util could be useful in those situation since waiting that the button becomes enabled. This solution is not 100% sure to fix the issue in all cases but manually disabling the button is creating the issue we can observe in those runbots. There is a good chance it might work. fixes-runbot-231582 fixes-runbot-233049 closes #227484 Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

This commit tries to solve runbot issues with mail html fields widget. It seems clicking on the save button manually is not generating a call to the backend. This could be due to the fact the button is not enabled due to the data being invalid. Therefore using the clickSave util could be useful in those situation since waiting that the button becomes enabled. This solution is not 100% sure to fix the issue in all cases but manually disabling the button is creating the issue we can observe in those runbots. There is a good chance it might work. fixes-runbot-231582 fixes-runbot-233049 closes odoo/odoo#227484 Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

This commit tries to solve runbot issues with mail html fields widget. It seems clicking on the save button manually is not generating a call to the backend. This could be due to the fact the button is not enabled due to the data being invalid. Therefore using the clickSave util could be useful in those situation since waiting that the button becomes enabled. This solution is not 100% sure to fix the issue in all cases but manually disabling the button is creating the issue we can observe in those runbots. There is a good chance it might work. fixes-runbot-231582 fixes-runbot-233049 closes odoo#227484 Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

KevGerard marked this pull request as ready for review September 16, 2025 14:48

C3POdoo requested review from a team September 16, 2025 14:51

seb-odoo reviewed Sep 16, 2025

View reviewed changes

KevGerard changed the title ~~[FIX] mail: fix runbot error 231582~~ [FIX] mail: fix runbot error 231582 (no web_save when manually saving) Sep 23, 2025

KevGerard force-pushed the 18.0-fix-runbot-error-231582-kege branch from f4796d2 to 6b41e1b Compare October 3, 2025 14:21

seb-odoo approved these changes Oct 7, 2025

View reviewed changes

robodoo temporarily deployed to merge October 7, 2025 13:13 Inactive

robodoo closed this Oct 7, 2025

This was referenced Oct 7, 2025

[FIX] mail: fix runbot error 231582 (no web_save when manually saving) #230311

Closed

[FIX] mail: fix runbot error 231582 (no web_save when manually saving) #230342

Closed

[FIX] mail: fix runbot error 231582 (no web_save when manually saving) #230375

Closed

This was referenced Oct 9, 2025

[FIX] mail: fix runbot error 231582 (no web_save when manually saving) #230710

Closed

[FIX] mail: fix runbot error 231582 (no web_save when manually saving) #230711

Closed

fw-bot deleted the 18.0-fix-runbot-error-231582-kege branch October 14, 2025 13:21

Uh oh!

Conversation

KevGerard commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robodoo commented Sep 16, 2025

Uh oh!

seb-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

seb-odoo commented Sep 16, 2025

Uh oh!

KevGerard commented Sep 16, 2025

Uh oh!

KevGerard commented Sep 16, 2025

Uh oh!

seb-odoo commented Sep 16, 2025

Uh oh!

seb-odoo Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

KevGerard Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

seb-odoo Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

KevGerard Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

seb-odoo Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

seb-odoo commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seb-odoo commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seb-odoo commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KevGerard commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KevGerard commented Sep 17, 2025

Uh oh!

seb-odoo commented Sep 17, 2025

Uh oh!

KevGerard commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seb-odoo commented Sep 29, 2025

Uh oh!

KevGerard commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seb-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

KevGerard commented Sep 16, 2025 •

edited

Loading

seb-odoo commented Sep 16, 2025 •

edited

Loading

seb-odoo commented Sep 16, 2025 •

edited

Loading

seb-odoo commented Sep 16, 2025 •

edited

Loading

KevGerard commented Sep 17, 2025 •

edited

Loading

KevGerard commented Sep 23, 2025 •

edited

Loading

KevGerard commented Oct 3, 2025 •

edited

Loading