[PERF] account: Avoid OOM error when processing batch payments - #236341
Closed
fw-bot wants to merge 1 commit into
Closed
[PERF] account: Avoid OOM error when processing batch payments#236341fw-bot wants to merge 1 commit into
fw-bot wants to merge 1 commit into
Conversation
Description: When trying to register a payment for multiple invoices, it is possible to trigger an Out Of Memory error. This is caused by the constraint `_validate_taxes_country`, calling the compute `_compute_tax_country_id` on all of the moves. To avoid that, we just retrieve the field we need rather than fetching everything. Reference: opw-5152687 X-original-commit: c956c15
Contributor
|
|
Contributor
Author
|
This PR targets saas-18.3 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
pushed a commit
that referenced
this pull request
Nov 24, 2025
Description: When trying to register a payment for multiple invoices, it is possible to trigger an Out Of Memory error. This is caused by the constraint `_validate_taxes_country`, calling the compute `_compute_tax_country_id` on all of the moves. To avoid that, we just retrieve the field we need rather than fetching everything. Reference: opw-5152687 closes #236341 X-original-commit: c956c15 Signed-off-by: Hugo Poncelet (hupo) <hupo@odoo.com> Signed-off-by: Aurélien Marie (auma) <auma@odoo.com>
fw-bot
deleted the
saas-18.3-17.0-OOM_compute_tax_country_id-opw-5152687-auma-478100-fw
branch
December 1, 2025 13:23
auma-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
Aug 20, 2026
Description: When trying to register a payment for multiple invoices, it is possible to trigger an Out Of Memory error. This is caused by the constraint `_validate_taxes_country`, calling the compute `_compute_tax_country_id` on all of the moves. To avoid that, we just retrieve the field we need rather than fetching everything. Reference: opw-5152687 closes odoo#236341 X-original-commit: c956c15 Signed-off-by: Hugo Poncelet (hupo) <hupo@odoo.com> Signed-off-by: Aurélien Marie (auma) <auma@odoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
When trying to register a payment for multiple invoices, it is possible to trigger an Out Of Memory error. This is caused by the constraint
_validate_taxes_country, calling the compute_compute_tax_country_idon all of the moves. To avoid that, we just retrieve the field we need rather than fetching everything.Reference:
opw-5152687
Forward-Port-Of: #235749