[FIX] base_import: handle CSV extension case-insensitively - #236348
Closed
fw-bot wants to merge 1 commit into
Closed
[FIX] base_import: handle CSV extension case-insensitively#236348fw-bot wants to merge 1 commit into
fw-bot wants to merge 1 commit into
Conversation
Contributor
|
|
robodoo
added
forwardport
Contributor
Author
|
@sauc-odoo @aab-odoo cherrypicking of pull request #235061 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Before this fix, the import side panel displayed the formatting options only when the uploaded file had a lowercase .csv extension. Files with an uppercase .CSV extension could still be imported but did not show the format selection section, leading to inconsistent behavior. This commit updates the condition to perform a case-insensitive comparison on the file extension. Task-5145031 X-original-commit: 33b4e76
sauc-odoo
force-pushed
the
saas-18.4-17.0-case-insensitive-csv-fix-sauc-478137-fw
branch
from
November 19, 2025 06:07
34e4188 to
bee2a0e
Compare
C3POdoo
requested review from
a team,
kmagusiak and
rugo-odoo
and removed request for
a team
November 19, 2025 06:10
Contributor
robodoo
pushed a commit
that referenced
this pull request
Nov 19, 2025
Before this fix, the import side panel displayed the formatting options only when the uploaded file had a lowercase .csv extension. Files with an uppercase .CSV extension could still be imported but did not show the format selection section, leading to inconsistent behavior. This commit updates the condition to perform a case-insensitive comparison on the file extension. Task-5145031 closes #236348 X-original-commit: 33b4e76 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com> Signed-off-by: Saurabh Choraria (sauc) <sauc@odoo.com>
This was referenced Nov 19, 2025
fw-bot
deleted the
saas-18.4-17.0-case-insensitive-csv-fix-sauc-478137-fw
branch
November 26, 2025 11:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this fix, the import side panel displayed the formatting options
only when the uploaded file had a lowercase .csv extension.
Files with an uppercase .CSV extension could still be imported but did
not show the format selection section, leading to inconsistent behavior.
This commit updates the condition to perform a
case-insensitive comparison on the file extension.
Task-5145031
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #236020
Forward-Port-Of: #235061